This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[WIP] Move Console usage of stat wrapper to new IO shim#2303
Closed
nguerrera wants to merge 2 commits into
Closed
Conversation
Contributor
Author
Contributor
Author
|
Note that this can't pass CI without dotnet/coreclr#1225 |
nguerrera
force-pushed
the
initial-io-shim
branch
from
77524c1 to
3f9ae39
Compare
Member
There was a problem hiding this comment.
Another big one is that exports can be named differently, making the DllImport mechanism itself quite challenging.
Contributor
Author
|
Replacing this with a new pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Managed half of dotnet/coreclr#1225 to get some feedback on the approach I'm leaning towards to address #2137.
See notes there. I've started to add some guidelines to the docs as well.