This repository was archived by the owner on Jan 23, 2023. It is now read-only.
avoid async overhead in ReadNextLineAsync#23329
Closed
geoffkizer wants to merge 2 commits into
Closed
Conversation
stephentoub
reviewed
Aug 17, 2017
| int length = _readLength - startIndex; | ||
| int crPos = Array.IndexOf(_readBuffer, (byte)'\r', startIndex, length); | ||
| if (crPos < 0) | ||
| await FillAsync(cancellationToken); |
stephentoub
reviewed
Aug 17, 2017
| { | ||
| while (true) | ||
| { | ||
| await FillAsync(cancellationToken); |
stephentoub
approved these changes
Aug 17, 2017
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Other than my comments, as long as perf looks good, LGTM.
Member
|
@geoffkizer what is the status of this PR? It's almost 3 weeks old now ... |
Member
|
@geoffkizer ping? |
Member
|
@geoffkizer any update? |
Member
|
@geoffkizer, did you want to move ahead with this PR? Or should we close it for now? |
Member
|
Closing for now. We can reopen later, when it is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated version of #23210
@stephentoub
I'm blocked on getting perf data here for now, but I expect it to be similar to the previous PR.