Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

revert part of #24098. do not use shell to find KDestroyCmd. #24682

Merged
danmoseley merged 1 commit into from
Oct 18, 2017
Merged

revert part of #24098. do not use shell to find KDestroyCmd. #24682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 8 additions & 25 deletions src/System.Net.Security/tests/FunctionalTests/NegotiateStreamTestForUnix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,31 +73,14 @@ public bool CheckAndClearCredentials(ITestOutputHelper output)
}

// Clear the credentials
try
{
var startInfo = new ProcessStartInfo(KDestroyCmd);
startInfo.UseShellExecute = true;
startInfo.CreateNoWindow = true;
startInfo.Arguments = "-A";
using (Process clearCreds = Process.Start(startInfo))
{
clearCreds.WaitForExit();
output.WriteLine("kdestroy returned {0}", clearCreds.ExitCode);
return (clearCreds.ExitCode == 0);
}
}
catch (Win32Exception)
{
// https://github.com/dotnet/corefx/issues/24000
// on these distros right now
Assert.True(PlatformDetection.IsUbuntu1704 ||
PlatformDetection.IsUbuntu1710 ||
PlatformDetection.IsOpenSUSE ||
PlatformDetection.IsFedora ||
PlatformDetection.IsDebian ||
PlatformDetection.IsCentos7);
Copy link
Copy Markdown
Member

@stephentoub stephentoub Oct 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer necessary?

Copy link
Copy Markdown
Member Author

@wfurt wfurt Oct 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure @stephentoub I was hoping that dotnet-bot would tell me. Since all this was introduced at the same time, I'm assuming that root cause is same e.g. we broke process.Start with shell flag.


return false;
var startInfo = new ProcessStartInfo(KDestroyCmd);
startInfo.CreateNoWindow = true;
startInfo.Arguments = "-A";
using (Process clearCreds = Process.Start(startInfo))
{
clearCreds.WaitForExit();
output.WriteLine("kdestroy returned {0}", clearCreds.ExitCode);
return (clearCreds.ExitCode == 0);
}
}

Expand Down