This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix casing in Interop.UnsafeCreateFile.[U|u]ap.cs filename#25185
Merged
stephentoub merged 1 commit intodotnet:masterfrom Nov 13, 2017
qmfrederik:fixes/casing
Merged
Fix casing in Interop.UnsafeCreateFile.[U|u]ap.cs filename#25185stephentoub merged 1 commit intodotnet:masterfrom qmfrederik:fixes/casing
stephentoub merged 1 commit intodotnet:masterfrom
qmfrederik:fixes/casing
Conversation
Member
|
Thanks, but I think it would be better to do the opposite fix; fixing the project file(s) to use ".Uap.cs" rather than ".uap.cs". While the repo isn't 100% consistent, most of these files use the upper-cased rather than lower-cased first letter. |
Author
|
That works as well ;-) |
Member
|
Thanks :) |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@025230b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The U in
Interop.UnsafeCreateFile.uap.cswas upper-case, this would break the./build.sh -allconfigurationscommand on my Linux box.