This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Convert uses of the Dangerous APIs to use MemoryMarshal.GetReference#25936
Merged
Conversation
3 tasks
| <Reference Include="System.Diagnostics.Contracts" /> | ||
| <Reference Include="System.Diagnostics.Debug" /> | ||
| <Reference Include="System.Diagnostics.Tools" /> | ||
| <Reference Include="System.Memory" /> |
Member
There was a problem hiding this comment.
Why did you have to add these?
Author
There was a problem hiding this comment.
MemoryMarshal is available through System.Memory.
jkotas
reviewed
Dec 16, 2017
| private unsafe static string CombineNoChecksInternal(ReadOnlySpan<char> first, ReadOnlySpan<char> second, ReadOnlySpan<char> third) | ||
| { | ||
| Debug.Assert(first.Length > 0 && second.Length > 0 && third.Length > 0, "should have dealt with empty paths"); | ||
| <<<<<<< HEAD |
Author
|
Waiting on #25961 before this will pass CI. |
Member
|
@dotnet-bot test this please |
1 similar comment
Member
|
@dotnet-bot test this please |
3 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…otnet/corefx#25936) * Convert uses of the Dangerous APIs to use MemoryMarshal.GetReference * Fix unresolved merge conflict. * Add using directive * Add missing using directives. * Add references to System.Memory Commit migrated from dotnet/corefx@40cbd56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of:
https://github.com/dotnet/corefx/issues/25412
https://github.com/dotnet/corefx/issues/25615
Related to (and depends on): dotnet/coreclr#15532
Note: Expecting this failure for now until we have resolved whether we should add
Unsafe.AsRef<T>(in T)or not. See: dotnet/coreclr#15532 (comment)Following the staging plan from here: https://github.com/dotnet/corefx/issues/23881#issuecomment-343767740
Doing it this way will avoid the need for complex staging or things being on the floor for extensive periods of time.
cc @jkotas, @stephentoub, @KrzysztofCwalina, @davidfowl, @pakrym, @joshfree