Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Adding scalar hardware intrinsics for x86#26095

Merged
tannergooding merged 2 commits into
dotnet:masterfrom
tannergooding:hwintrin-scalar
Dec 29, 2017
Merged

Adding scalar hardware intrinsics for x86#26095
tannergooding merged 2 commits into
dotnet:masterfrom
tannergooding:hwintrin-scalar

Conversation

@tannergooding
Copy link
Copy Markdown
Member

@tannergooding tannergooding commented Dec 29, 2017

This is the CoreFX side of dotnet/coreclr#15341 and adds the contracts for the new APIs approved in dotnet/corefx#23519

@tannergooding
Copy link
Copy Markdown
Member Author

Several of the existing APIs don't follow the { throw null; } convention and instead throw other exceptions. Should they be updated as part of this PR, or separately?

@tannergooding
Copy link
Copy Markdown
Member Author

FYI. @fiigii, @eerhardt

@tannergooding
Copy link
Copy Markdown
Member Author

tannergooding commented Dec 29, 2017

Rebased onto head. The CoreCLR side has been pumped back, so this should pass now.

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Dec 29, 2017

Should they be updated as part of this PR, or separately?

Yes, it would be nice to get them updated. Either second commit in this PR, or a new PR are fine.

@tannergooding
Copy link
Copy Markdown
Member Author

Updated as part of this PR.

Am I good to merge once tests are green?

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Dec 29, 2017

Yes (with Rebase & Merge).

@tannergooding tannergooding merged commit a011ef1 into dotnet:master Dec 29, 2017
@tannergooding
Copy link
Copy Markdown
Member Author

Merged with rebase and merge. Thanks!

@karelz karelz added this to the 2.1.0 milestone Jan 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants