Re-enable initlocals clearing in System.Net.Sockets on Unix#27411
Conversation
We disabled it because some ReceiveMessageFrom tests were failing. The issue turned out to be that we weren't explicitly clearing an IP packet information struct before handing it to native code, and the native code wasn't clearing it. This fixes that. Along with it, I initialized a few other variables, just for good measure.
|
@stephentoub not related to you commit, but the title hit me, what do you use to dev coreclr/corefx on unix?I worked with vscode on ubuntu(xfce) vm for a past PR, but it's not so easy, vscode it's a great growing ide, but some features doesn't work well with corefx solutions/projects(intellisense on top). Can you give me some advice? Thank's in advance for your time, if ask here is not correct i'll remove. |
|
@dotnet-bot test Linux x64 Release Build please (seg fault in System.Xml.XmlSchemaSet.Tests, which doesn't have any dependencies on System.Net.Sockets) |
I generally just use Visual Studio on Windows. I've got WSL set up and do lots of Unix testing locally. If I need to target a particular distro/version, I often set up a VM in Azure and ssh into it, then use vim. |
…orefx#27411) We disabled it because some ReceiveMessageFrom tests were failing. The issue turned out to be that we weren't explicitly clearing an IP packet information struct before handing it to native code, and the native code wasn't clearing it. This fixes that. Along with it, I initialized a few other variables, just for good measure. Commit migrated from dotnet/corefx@1885cf8
5 participants
We disabled it because some ReceiveMessageFrom tests were failing. The issue turned out to be that we weren't explicitly clearing an IPPacketInformation struct before handing it to native code, and the native code wasn't clearing it. This fixes that (https://github.com/dotnet/corefx/pull/27411/files#diff-74b2e83ee829756a9dc8177b5154b7f7R50). Along with it, I initialized a few other variables, just for good measure.
Fixes https://github.com/dotnet/corefx/issues/27392
cc: @erozenfeld, @geoffkizer