Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Dial back \\?\ insertion#27827

Merged
JeremyKuhne merged 1 commit into
dotnet:masterfrom
JeremyKuhne:info2
Mar 7, 2018
Merged

Dial back \\?\ insertion#27827
JeremyKuhne merged 1 commit into
dotnet:masterfrom
JeremyKuhne:info2

Conversation

@JeremyKuhne
Copy link
Copy Markdown
Member

@JeremyKuhne JeremyKuhne commented Mar 7, 2018

Only premptively adding for FileSystemInfo if we end in period or space.
Long path is taken care of later.

Clean up code a little and add test for DirectoryInfo.Move.

cc: @danmosemsft, @pjanotti, @Anipik

@JeremyKuhne
Dial back \\?\ insertion
3b0a408 
Only premptively adding for FileSystemInfo if we end in period or space.
Long path is taken care of later.

Clean up code a little and add test for DirectoryInfo.Move.
@JeremyKuhne JeremyKuhne added this to the 2.1.0 milestone Mar 7, 2018
@JeremyKuhne JeremyKuhne self-assigned this Mar 7, 2018
@JeremyKuhne
Copy link
Copy Markdown
Member Author

JeremyKuhne commented Mar 7, 2018

@dotnet-bot test Packaging All Configurations x64 Debug Build

TGroup_all+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/9338/ and message: 'Build finished. '
Using context: Packaging All Configurations x64 Debug Build
java.io.FileNotFoundException: /jenkins/jobs/dotnet_corefx/jobs/master/jobs/windows-TGroup_all+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/builds/9338/program.dat (No such file or directory)

@JeremyKuhne
Copy link
Copy Markdown
Member Author

JeremyKuhne commented Mar 7, 2018 •
edited
Loading

@dotnet/dncenghot The Linux x64 release builds seem stuck- I'm seeing runs looping for the past few hours trying to get results from Ubuntu 1804.

@danmoseley
Copy link
Copy Markdown
Member

danmoseley commented Mar 7, 2018

I think we are supposed to use @dotnet/dnceng or @dotnet/dncenghot . I don't know what @dotnet/eng-first is for.

@JeremyKuhne
Copy link
Copy Markdown
Member Author

JeremyKuhne commented Mar 7, 2018

I think we are supposed to use @dotnet/dnceng or @dotnet/dncenghot . I don't know what @dotnet/eng-first is for.

Auto completed to that, not sure why.

@markwilkie
Copy link
Copy Markdown
Member

markwilkie commented Mar 7, 2018

@dagood - can you take a look?

@jonfortescue
Copy link
Copy Markdown
Contributor

jonfortescue commented Mar 7, 2018

@riarenas Does this look similar to the infinite hang issue we were having in some of the win images?

@ghost
Copy link
Copy Markdown

ghost commented Mar 7, 2018

Nope, doesn't look similar. What I got to take a look at was that it seems to be waiting for 231 workitems to even start running.

@jonfortescue
Copy link
Copy Markdown
Contributor

jonfortescue commented Mar 7, 2018 •
edited
Loading

@riarenas yeah I thought it might be a longshot but wanted to check anyway. I'm wondering why it's not timing out. @mmitche – any ideas?

@dagood
Copy link
Copy Markdown
Member

dagood commented Mar 7, 2018 •
edited
Loading

I noticed https://github.com/dotnet/core-eng/issues/2755 (link to spawning PR comment: #27449 (comment)) that was also about the Ubuntu 1804 runs hanging, but it says it's fixed. @MattGal, any ideas?

@dagood
Copy link
Copy Markdown
Member

dagood commented Mar 7, 2018

I checked the Ubuntu.1804.Amd64.Open scaleset in Azure, and it is marked Failed.

@dagood
Copy link
Copy Markdown
Member

dagood commented Mar 7, 2018 •
edited
Loading

It is no longer marked failed, and Ubuntu.1804.Amd64.Open getting more instances. (There was only one when I looked before.) It's unclear to me what happened, but @MattGal may have fixed it. Since the CI is still hanging (edit: the queue was draining, so the items did finish) and there doesn't appear to be any progress on the items, I would assume you should retry it now, but I'm hoping Matt can clear this up.

@jonfortescue
Copy link
Copy Markdown
Contributor

jonfortescue commented Mar 7, 2018

It looks like we have filed an issue against this: #2839

@JeremyKuhne JeremyKuhne merged commit cc4abca into dotnet:master Mar 7, 2018
@JeremyKuhne JeremyKuhne deleted the info2 branch March 7, 2018 23:58
dotnet-bot pushed a commit to dotnet/coreclr that referenced this pull request Mar 8, 2018
@JeremyKuhne @dotnet-bot
Dial back \\?\ insertion (dotnet/corefx#27827)
24c0dc6 
Only premptively adding for FileSystemInfo if we end in period or space.
Long path is taken care of later.

Clean up code a little and add test for DirectoryInfo.Move.

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
jkotas pushed a commit to dotnet/coreclr that referenced this pull request Mar 8, 2018
@JeremyKuhne @jkotas
Dial back \\?\ insertion (dotnet/corefx#27827)
5928c09 
Only premptively adding for FileSystemInfo if we end in period or space.
Long path is taken care of later.

Clean up code a little and add test for DirectoryInfo.Move.

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot pushed a commit to dotnet/corert that referenced this pull request Mar 8, 2018
@JeremyKuhne @dotnet-bot
Dial back \\?\ insertion (dotnet/corefx#27827)
7297969 
Only premptively adding for FileSystemInfo if we end in period or space.
Long path is taken care of later.

Clean up code a little and add test for DirectoryInfo.Move.

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas pushed a commit to dotnet/corert that referenced this pull request Mar 8, 2018
@JeremyKuhne @jkotas
Dial back \\?\ insertion (dotnet/corefx#27827)
3c292ac 
Only premptively adding for FileSystemInfo if we end in period or space.
Long path is taken care of later.

Clean up code a little and add test for DirectoryInfo.Move.

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
caesar-chen pushed a commit to caesar-chen/corefx that referenced this pull request Mar 8, 2018
@JeremyKuhne @caesar-chen
Dial back \\?\ insertion (dotnet#27827)
2bca9c2 
Only premptively adding for FileSystemInfo if we end in period or space.
Long path is taken care of later.

Clean up code a little and add test for DirectoryInfo.Move.
kbaladurin pushed a commit to kbaladurin/corert that referenced this pull request Mar 15, 2018
@JeremyKuhne
Dial back \\?\ insertion (dotnet/corefx#27827)
028a8b2 
Only premptively adding for FileSystemInfo if we end in period or space.
Long path is taken care of later.

Clean up code a little and add test for DirectoryInfo.Move.

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@JeremyKuhne
Dial back \\?\ insertion (dotnet/corefx#27827)
afb3e61 
Only premptively adding for FileSystemInfo if we end in period or space.
Long path is taken care of later.

Clean up code a little and add test for DirectoryInfo.Move.

Commit migrated from dotnet/corefx@cc4abca
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@danmoseley danmoseley danmoseley approved these changes

@Anipik Anipik Anipik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JeremyKuhne JeremyKuhne

Labels

area-System.IO

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@JeremyKuhne @danmoseley @markwilkie @jonfortescue @dagood @Anipik