ROS: Don't skip blocks passed end#28261
Conversation
|
|
||
| // Go out of bounds for segment | ||
| Assert.Throws<ArgumentOutOfRangeException>(() => c1 = buffer.GetPosition(150, buffer.Start)); | ||
| Assert.Throws<ArgumentOutOfRangeException>(() => c1 = buffer.GetPosition(250, buffer.Start)); |
There was a problem hiding this comment.
These asserts currently work; just adding for completeness
|
|
||
| // Go out of bounds for segment | ||
| Assert.Throws<ArgumentOutOfRangeException>(() => c1 = buffer.GetPosition(150, buffer.Start)); | ||
| Assert.Throws<ArgumentOutOfRangeException>(() => c1 = buffer.GetPosition(250, buffer.Start)); |
There was a problem hiding this comment.
These asserts are where it currently breaks as it skips the blocks without checking if its already hit the end
|
@Petermarcu @karelz @joshfree We want this in preview2, do we need to change the branch? |
Added a 2.1 branch version #28262; though I don't know correct process |
Getting this into master is still fine for preview2 at this point, I believe. There should be another mop up integration to the release branch after the bug bounce. @leecow it would be great to publish the schedule soon 😄 |
|
@joshfree - it's coming any minute now :-P |
|
Alpine and OSX are Which is a buildtools issue? |
Yes, @Anipik fixed the issue in dotnet/buildtools#1969. |
|
@dotnet-bot test Alpine.3.6 x64 Debug Build |
|
This PR is be superseded by #28294; is that correct @ahsonkhan ? |
7 participants
Seen in #28095 (comment)
/cc @AlexRadch @pakrym @davidfowl @ahsonkhan