Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Update buildtools to 2.1.0-preview2-02621-01#28290

Merged
danmoseley merged 1 commit into
dotnet:release/2.1from
mmitche:update-buildtools
Mar 21, 2018
Merged

Update buildtools to 2.1.0-preview2-02621-01#28290
danmoseley merged 1 commit into
dotnet:release/2.1from
mmitche:update-buildtools

Conversation

@mmitche
Copy link
Copy Markdown
Member

@mmitche mmitche commented Mar 21, 2018

Fixes issue with dumpling dotnet/buildtools#1972

@stephentoub
Copy link
Copy Markdown
Member

@mmitche, your Linux leg has been running for over six hours.
https://ci3.dot.net/job/dotnet_corefx/job/release_2.1/job/linux-TGroup_netcoreapp+CGroup_Release+AGroup_x64+TestOuter_false_prtest/54/
Do we know what's causing this? I've seen lots of similar length legs recently. @joperezr, should the buildtools update have fixed this?

@stephentoub
Copy link
Copy Markdown
Member

Ah, I see @joshfree already opened an issue related to it.

@danmoseley
Copy link
Copy Markdown
Member

@mmitche it shows System.Odbc tests are still running, but their execution logs show they completed successfully.

https://mc.dot.net/#/user/mmitche/pr~2Fjenkins~2Fdotnet~2Fcorefx~2Frelease~2F2.1~2F/test~2Ffunctional~2Fcli~2F/d844702aad4b93f903c8d54e0b6614ee17898f2f

@danmoseley
Copy link
Copy Markdown
Member

I'm going to merge this as everything seems complete and passing and this is fixing a build break.

@danmoseley danmoseley merged commit e6b58fa into dotnet:release/2.1 Mar 21, 2018
@mmitche
Copy link
Copy Markdown
Member Author

mmitche commented Mar 21, 2018

Thanks.

@joperezr
Copy link
Copy Markdown
Member

@joperezr Jose Perez Rodriguez FTE, should the buildtools update have fixed this?

No, the buildtools update was only really meant to speed up build time for non-Windows builds. This issue seems to be something related to either Jenkins or Helix who is just waiting forever.

@MattGal
Copy link
Copy Markdown
Member

MattGal commented Mar 21, 2018

It's an infra bug, I put details in Josh's issue. Things hitting this bug will indeed never finish unless we send a fake event for them.

@karelz karelz added this to the 2.1.0 milestone Mar 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants