Mirror changes from dotnet/coreclr#29012
Conversation
* Add CreateFromPinnedArray to MemoryMarshal * Address PR feedback: Add a warning remark to CreateFromPinnedArray Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
|
Cherry-picked this change into #28992 |
|
@ahsonkhan, @Anipik, some other changes are blocked behind this. How can we get the mirror flowing again? |
|
@stephentoub are these missing changes necessary for this PR to get merged ? if not I will wait for this pr to get merged, otherwise I will close this one and reopen the PR for missing commits first |
No, but I don't think this PR is going to be merged. I believe @ahsonkhan cherry-picked the changes from this PR into #28992, which hasn't been merged yet. Maybe we need to wait for that one to merge and then close this one? I don't fully understand how the mirror works in that regard. |
Yes. |
|
@ahsonkhan why do we need to wait to close this one ? |
If you close this before the other PR is merged, won't another one get re-opened with the exact same changes (and block on CI)? |
|
@ahsonkhan it depends upon the history actually. I may be able to stop the commit from happening. I will close this one and open the mirror with the missing commits |
4 participants
This PR contains mirrored changes from dotnet/coreclr
Please REBASE this PR when merging