This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Lock Vectors reference assembly to 4.1.3.0 and don't OOB it on netcoreapp2.0#29183
Merged
ericstj merged 1 commit intodotnet:masterfrom Apr 20, 2018
Merged
Lock Vectors reference assembly to 4.1.3.0 and don't OOB it on netcoreapp2.0#29183ericstj merged 1 commit intodotnet:masterfrom
ericstj merged 1 commit intodotnet:masterfrom
Conversation
…eapp2.0 System.Numerics.Vectors was made inbox in netcoreapp2.0, we were still allowing distribution in the package, however the package was applying the netstandard2.0 implementation to netcoreapp2.0. Now that we've disabled oobing the netcoreapp2.1 build (since many types were moved into corelib) it no longer makes sense for us to mantain the ability to oob the netcoreapp2.0 build. Doing so not only degrades the inbox version (by not using the framework's MathF implementation) but also creates type-unfication issues on rollforward: app targets 2.0 carries OOB copy of Vectors with higher version than 2.1, rolls forward to 2.1 and host will use the OOB copy, no longer unifying to the types in corelib.
Member
Author
|
Test Linux x64 Release Build |
weshaggard
approved these changes
Apr 18, 2018
ericstj
added
the
* NO MERGE *
Member
Author
|
Waiting on approval for release side of changes before merging. |
ahsonkhan
reviewed
Apr 20, 2018
| <IsPartialFacadeAssembly Condition="'$(IsTargetingNetFx)'=='true'">true</IsPartialFacadeAssembly> | ||
| <DefineConstants Condition="'$(IsTargetingNetCoreApp)'=='true'">$(DefineConstants);netcoreapp</DefineConstants> | ||
| <IsPartialFacadeAssembly Condition="'$(TargetsNetFx)'=='true' AND '$(TargetGroup)' != 'net45'">true</IsPartialFacadeAssembly> | ||
| <DefineConstants Condition="'$(TargetsNetCoreApp)'=='true' OR '$(TargetsUap)' == 'true'">$(DefineConstants);HAS_SPAN</DefineConstants> |
There was a problem hiding this comment.
Why was this change to rename the constant necessary? Is keeping it netcoreapp semantically incorrect now?
Member
Author
There was a problem hiding this comment.
No, it was semantically incorrect before because it was set for both netcoreapp and uap.
ericstj
removed
the
* NO MERGE *
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…eapp2.0 (dotnet/corefx#29183) System.Numerics.Vectors was made inbox in netcoreapp2.0, we were still allowing distribution in the package, however the package was applying the netstandard2.0 implementation to netcoreapp2.0. Now that we've disabled oobing the netcoreapp2.1 build (since many types were moved into corelib) it no longer makes sense for us to mantain the ability to oob the netcoreapp2.0 build. Doing so not only degrades the inbox version (by not using the framework's MathF implementation) but also creates type-unfication issues on rollforward: app targets 2.0 carries OOB copy of Vectors with higher version than 2.1, rolls forward to 2.1 and host will use the OOB copy, no longer unifying to the types in corelib. Commit migrated from dotnet/corefx@c3c2faa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.Numerics.Vectors was made inbox in netcoreapp2.0, we were still allowing distribution
in the package, however the package was applying the netstandard2.0 implementation to
netcoreapp2.0.
Now that we've disabled oobing the netcoreapp2.1 build (since many types were moved into
corelib) it no longer makes sense for us to mantain the ability to oob the netcoreapp2.0 build.
Doing so not only degrades the inbox version (by not using the framework's MathF
implementation) but also creates type-unfication issues on rollforward: app targets 2.0
carries OOB copy of Vectors with higher version than 2.1, rolls forward to 2.1 and host will
use the OOB copy, no longer unifying to the types in corelib.
Master branch version of #29182.
We should only merge in master if we're certain we're taking the release side of the fix.