This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/2.1] Fix Process.ExitCode on mac for killed processes (#29407)#29445
Merged
stephentoub merged 1 commit intodotnet:release/2.1from May 2, 2018
Merged
[release/2.1] Fix Process.ExitCode on mac for killed processes (#29407)#29445stephentoub merged 1 commit intodotnet:release/2.1from
stephentoub merged 1 commit intodotnet:release/2.1from
Conversation
* Fix Process.ExitCode on mac for killed processes dotnet#26291 changed process reaping from using waitpid to waitid. This caused a regression on mac, since for processes that are killed, (on mac) waitid does not return the signal number that caused the process to terminated. We change back to waitpid for reaping children and determining the exit code. waitid is used to find terminated children. Fixes https://github.com/dotnet/corefx/issues/29370 * TestExitCodeKilledChild: remove runtime check * TestExitCodeKilledChild: remove greater than assert
Member
|
Thanks Jose! Did you also send email to shiproom? |
Member
Author
|
@wtgodbe doing that now 😄 |
stephentoub
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of #29407 into the release/2.1 branch that will fix a regression on Process.ExitCode on mac for processes that are killed.
There was one small merge conflict on
https://github.com/joperezr/corefx/blob/806c5b270e299a8b4a06310c192b4e612f9e8607/src/Native/Unix/System.Native/pal_process.h#L215-L225
that required me to get rid of the
DLLEXPORTkeywords at the beginning of those two functions. Nothing else had to be changed.cc: @tmds @stephentoub @danmosemsft @wtgodbe
Fixes: #29370
Master PR commit message: