Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BuildToolsVersion.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.2.0-preview1-02810-02
2.2.0-preview1-02815-01
34 changes: 17 additions & 17 deletions dependencies.props
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@
These ref versions are pulled from https://github.com/dotnet/versions.
-->
<PropertyGroup>
<CoreFxCurrentRef>808a3dd4f4a0c80eb868e5b7425ffeaf8fcd8c85</CoreFxCurrentRef>
<CoreClrCurrentRef>08a3c9892de333438b450fcb1228334e8f72310e</CoreClrCurrentRef>
<CoreSetupCurrentRef>08a3c9892de333438b450fcb1228334e8f72310e</CoreSetupCurrentRef>
<CoreFxCurrentRef>740ad52a71898d36e00847c3ba134d0aaa0d0460</CoreFxCurrentRef>
<CoreClrCurrentRef>740ad52a71898d36e00847c3ba134d0aaa0d0460</CoreClrCurrentRef>
<CoreSetupCurrentRef>740ad52a71898d36e00847c3ba134d0aaa0d0460</CoreSetupCurrentRef>
<ExternalCurrentRef>96dc7805f5df4a70a55783964ce69dcd91bfca80</ExternalCurrentRef>
<ProjectNTfsCurrentRef>808a3dd4f4a0c80eb868e5b7425ffeaf8fcd8c85</ProjectNTfsCurrentRef>
<ProjectNTfsTestILCCurrentRef>808a3dd4f4a0c80eb868e5b7425ffeaf8fcd8c85</ProjectNTfsTestILCCurrentRef>
<ProjectNTfsCurrentRef>740ad52a71898d36e00847c3ba134d0aaa0d0460</ProjectNTfsCurrentRef>
<ProjectNTfsTestILCCurrentRef>740ad52a71898d36e00847c3ba134d0aaa0d0460</ProjectNTfsTestILCCurrentRef>
<SniCurrentRef>8bd1ec5fac9f0eec34ff6b34b1d878b4359e02dd</SniCurrentRef>
<StandardCurrentRef>5077f4a159e71ee4c4801adb1f426b895ecd961b</StandardCurrentRef>
<BuildToolsCurrentRef>7d8f7c738b9d8081e4bb8929755b46af6c308c6d</BuildToolsCurrentRef>
<BuildToolsCurrentRef>740ad52a71898d36e00847c3ba134d0aaa0d0460</BuildToolsCurrentRef>
</PropertyGroup>

<!-- Product dependency versions. -->
Expand All @@ -31,23 +31,23 @@

<!-- Tests/infrastructure dependency versions. -->
<PropertyGroup>
<CoreFxExpectedPrerelease>preview1-26514-01</CoreFxExpectedPrerelease>
<MicrosoftNETCorePlatformsPackageVersion>2.2.0-preview1-26514-01</MicrosoftNETCorePlatformsPackageVersion>
<MicrosoftNETCoreRuntimeCoreCLRPackageVersion>2.2.0-preview1-26514-05</MicrosoftNETCoreRuntimeCoreCLRPackageVersion>
<ProjectNTfsExpectedPrerelease>beta-26514-00</ProjectNTfsExpectedPrerelease>
<ProjectNTfsTestILCExpectedPrerelease>beta-26514-00</ProjectNTfsTestILCExpectedPrerelease>
<ProjectNTfsTestILCPackageVersion>1.0.0-beta-26514-00</ProjectNTfsTestILCPackageVersion>
<MicrosoftNETCoreDotNetHostPackageVersion>2.2.0-preview1-26514-01</MicrosoftNETCoreDotNetHostPackageVersion>
<MicrosoftNETCoreDotNetHostPolicyPackageVersion>2.2.0-preview1-26514-01</MicrosoftNETCoreDotNetHostPolicyPackageVersion>
<MicrosoftNETCoreAppPackageVersion>2.2.0-preview1-26514-01</MicrosoftNETCoreAppPackageVersion>
<CoreFxExpectedPrerelease>preview1-26515-04</CoreFxExpectedPrerelease>
<MicrosoftNETCorePlatformsPackageVersion>2.2.0-preview1-26515-04</MicrosoftNETCorePlatformsPackageVersion>
<MicrosoftNETCoreRuntimeCoreCLRPackageVersion>2.2.0-preview1-26515-05</MicrosoftNETCoreRuntimeCoreCLRPackageVersion>
<ProjectNTfsExpectedPrerelease>beta-26515-00</ProjectNTfsExpectedPrerelease>
<ProjectNTfsTestILCExpectedPrerelease>beta-26515-00</ProjectNTfsTestILCExpectedPrerelease>
<ProjectNTfsTestILCPackageVersion>1.0.0-beta-26515-00</ProjectNTfsTestILCPackageVersion>
<MicrosoftNETCoreDotNetHostPackageVersion>2.2.0-preview1-26515-01</MicrosoftNETCoreDotNetHostPackageVersion>
<MicrosoftNETCoreDotNetHostPolicyPackageVersion>2.2.0-preview1-26515-01</MicrosoftNETCoreDotNetHostPolicyPackageVersion>
<MicrosoftNETCoreAppPackageVersion>2.2.0-preview1-26515-01</MicrosoftNETCoreAppPackageVersion>

<!-- CoreFX-built SNI identity package -->
<RuntimeNativeSystemDataSqlClientSniPackageVersion>4.4.0</RuntimeNativeSystemDataSqlClientSniPackageVersion>

<AppXRunnerVersion>1.0.3-prerelease-00921-01</AppXRunnerVersion>
<XunitPerfAnalysisPackageVersion>1.0.0-beta-build0019</XunitPerfAnalysisPackageVersion>
<TraceEventPackageVersion>2.0.5</TraceEventPackageVersion>
<XunitNetcoreExtensionsVersion>2.2.0-preview1-02810-02</XunitNetcoreExtensionsVersion>
<XunitNetcoreExtensionsVersion>2.2.0-preview1-02815-01</XunitNetcoreExtensionsVersion>

<!-- Roslyn optimization data package version -->
<OptimizationDataVersion>2.0.0-rc-61101-17</OptimizationDataVersion>
Expand All @@ -56,7 +56,7 @@
<!-- Package versions used as toolsets -->
<PropertyGroup>
<FeedTasksPackage>Microsoft.DotNet.Build.Tasks.Feed</FeedTasksPackage>
<FeedTasksPackageVersion>2.2.0-preview1-02810-02</FeedTasksPackageVersion>
<FeedTasksPackageVersion>2.2.0-preview1-02815-01</FeedTasksPackageVersion>
</PropertyGroup>

<!-- Publish symbol build task package -->
Expand Down
6 changes: 3 additions & 3 deletions external/test-runtime/optional.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"net45": {
"dependencies": {
"Microsoft.DotNet.IBCMerge": "4.6.0-alpha-00001",
"TestILC.amd64ret": "1.0.0-beta-26514-00",
"TestILC.armret": "1.0.0-beta-26514-00",
"TestILC.x86ret": "1.0.0-beta-26514-00"
"TestILC.amd64ret": "1.0.0-beta-26515-00",
"TestILC.armret": "1.0.0-beta-26515-00",
"TestILC.x86ret": "1.0.0-beta-26515-00"
}
}
}
Expand Down
20 changes: 20 additions & 0 deletions src/Common/src/Internal/Padding.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.Runtime.InteropServices;

namespace Internal
{
/// <summary>A placeholder class for common padding constants and eventually routines.</summary>
internal static class PaddingHelpers
{
/// <summary>A size greater than or equal to the size of the most common CPU cache lines.</summary>
internal const int CACHE_LINE_SIZE = 128;
}

/// <summary>Padding structure used to minimize false sharing in SingleProducerSingleConsumerQueue{T}.</summary>
[StructLayout(LayoutKind.Explicit, Size = PaddingHelpers.CACHE_LINE_SIZE - sizeof(int))] // Based on common case of 64-byte cache lines
internal struct PaddingFor32 { }
}

Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.Diagnostics;
using System.Runtime.InteropServices;
using System.Threading;
using Internal;

namespace System.Collections.Concurrent
{
Expand Down Expand Up @@ -300,16 +301,4 @@ public SingleProducerSingleConsumerQueue_DebugView(SingleProducerSingleConsumerQ
public T[] Items => new List<T>(_queue).ToArray();
}
}


/// <summary>A placeholder class for common padding constants and eventually routines.</summary>
internal static class PaddingHelpers
{
/// <summary>A size greater than or equal to the size of the most common CPU cache lines.</summary>
internal const int CACHE_LINE_SIZE = 128;
}

/// <summary>Padding structure used to minimize false sharing in SingleProducerSingleConsumerQueue{T}.</summary>
[StructLayout(LayoutKind.Explicit, Size = PaddingHelpers.CACHE_LINE_SIZE - sizeof(int))] // Based on common case of 64-byte cache lines
internal struct PaddingFor32 { }
}
3 changes: 2 additions & 1 deletion src/System.Collections.Concurrent/src/Configurations.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<BuildConfigurations>
netcoreapp;
uap-Windows_NT;
netcoreapp-Windows_NT;
netcoreapp-Unix;
</BuildConfigurations>
</PropertyGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<ProjectGuid>{EA610394-CBA3-4E5C-B3DB-AAEA7F640E89}</ProjectGuid>
<AssemblyName>System.Collections.Concurrent</AssemblyName>
<RootNamespace>System.Collections.Concurrent</RootNamespace>
<IsPartialFacadeAssembly>true</IsPartialFacadeAssembly>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'netcoreapp-Debug|AnyCPU'" />
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'netcoreapp-Release|AnyCPU'" />
Expand All @@ -15,27 +16,26 @@
<Compile Include="System\Collections\Concurrent\CDSCollectionETWBCLProvider.cs" />
<Compile Include="System\Collections\Concurrent\ConcurrentBag.cs" />
<Compile Include="System\Collections\Concurrent\ConcurrentDictionary.cs" />
<Compile Include="System\Collections\Concurrent\ConcurrentQueue.cs" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to keep these .cs files in for uapaot build until the change propagates to ProjectN.

<Compile Include="System\Collections\Concurrent\ConcurrentStack.cs" />
<Compile Include="System\Collections\Concurrent\IProducerConsumerCollection.cs" />
<Compile Include="System\Collections\Concurrent\OrderablePartitioner.cs" />
<Compile Include="System\Collections\Concurrent\Partitioner.cs" />
<Compile Include="System\Collections\Concurrent\PartitionerStatic.cs" />
<Compile Include="System\Collections\Concurrent\PlatformHelper.cs" />
<Compile Include="$(CommonPath)\System\Collections\Concurrent\ConcurrentQueue_Segment.cs">
<Link>Common\System\Collections\Concurrent\ConcurrentQueue_Segment.cs</Link>
<Compile Include="$(CommonPath)\CoreLib\System\Collections\Concurrent\IProducerConsumerCollectionDebugView.cs">
<Link>Common\CoreLib\System\Collections\Concurrent\IProducerConsumerCollectionDebugView.cs</Link>
</Compile>
</ItemGroup>
<ItemGroup>
<Reference Include="System.Collections" />
<Reference Include="System.Diagnostics.Debug" />
<Reference Include="System.Diagnostics.Tools" />
<Reference Include="System.Diagnostics.Tracing" />
<Reference Include="System.Resources.ResourceManager" />
<Reference Include="System.Runtime" />
<Reference Include="System.Runtime.Extensions" />
<Reference Include="System.Threading" />
<Reference Include="System.Threading.Tasks" />
<ReferenceFromRuntime Include="System.Private.CoreLib" />
<ProjectReference Include="..\..\System.Collections\src\System.Collections.csproj" />
<ProjectReference Include="..\..\System.Diagnostics.Debug\src\System.Diagnostics.Debug.csproj" />
<ProjectReference Include="..\..\System.Diagnostics.Tools\src\System.Diagnostics.Tools.csproj" />
<ProjectReference Include="..\..\System.Diagnostics.Tracing\src\System.Diagnostics.Tracing.csproj" />
<ProjectReference Include="..\..\System.Numerics.Vectors\src\System.Numerics.Vectors.csproj" />
<ProjectReference Include="..\..\System.Runtime\src\System.Runtime.csproj" />
<ProjectReference Include="..\..\System.Runtime.Extensions\src\System.Runtime.Extensions.csproj" />
<ProjectReference Include="..\..\System.Threading\src\System.Threading.csproj" />
<ProjectReference Include="..\..\System.Threading.Tasks\src\System.Threading.Tasks.csproj" />
</ItemGroup>
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
<Compile Include="$(CommonTestPath)\System\Collections\DictionaryExtensions.cs" Condition="'$(TargetGroup)'!='netcoreapp'">
<Link>Common\System\Collections\DictionaryExtensions.cs</Link>
</Compile>
<Compile Include="$(CommonPath)\CoreLib\System\Collections\Concurrent\IProducerConsumerCollectionDebugView.cs">
<Link>Common\CoreLib\System\Collections\Concurrent\IProducerConsumerCollectionDebugView.cs</Link>
</Compile>
<!-- Common Collections tests -->
<Compile Include="$(CommonTestPath)\System\Collections\CollectionAsserts.cs">
<Link>Common\System\Collections\CollectionAsserts.cs</Link>
Expand Down
7 changes: 5 additions & 2 deletions src/System.Net.Http/src/System.Net.Http.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,11 @@
<Compile Include="System\Net\Http\SocketsHttpHandler\SocketsHttpHandler.cs" />
<Compile Include="System\Net\Http\SocketsHttpHandler\RawConnectionStream.cs" />
<Compile Include="System\Net\Http\SocketsHttpHandler\RedirectHandler.cs" />
<Compile Include="$(CommonPath)\System\Collections\Concurrent\ConcurrentQueue_Segment.cs">
<Link>Common\System\Collections\Concurrent\ConcurrentQueue_Segment.cs</Link>
<Compile Include="$(CommonPath)\CoreLib\System\Collections\Concurrent\ConcurrentQueueSegment.cs">
<Link>Common\CoreLib\System\Collections\Concurrent\ConcurrentQueueSegment.cs</Link>
</Compile>
<Compile Include="$(CommonPath)\Internal\Padding.cs">
<Link>Common\Internal\Padding.cs</Link>
</Compile>
<Compile Include="$(CommonPath)\System\Net\NTAuthentication.Common.cs">
<Link>Common\System\Net\NTAuthentication.Common.cs</Link>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ namespace System.Net.Http
internal static class ConnectHelper
{
/// <summary>Pool of event args to use to establish connections.</summary>
private static readonly ConcurrentQueue<ConnectEventArgs>.Segment s_connectEventArgs =
new ConcurrentQueue<ConnectEventArgs>.Segment(
ConcurrentQueue<ConnectEventArgs>.Segment.RoundUpToPowerOf2(Math.Max(2, Environment.ProcessorCount)));
private static readonly ConcurrentQueueSegment<ConnectEventArgs> s_connectEventArgs =
new ConcurrentQueueSegment<ConnectEventArgs>(
ConcurrentQueueSegment<ConnectEventArgs>.RoundUpToPowerOf2(Math.Max(2, Environment.ProcessorCount)));

/// <summary>
/// Helper type used by HttpClientHandler when wrapping SocketsHttpHandler to map its
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
<Compile Include="System\Threading\Channels\AsyncOperation.cs" />
<Compile Include="System\Threading\Channels\SingleConsumerUnboundedChannel.cs" />
<Compile Include="System\Threading\Channels\UnboundedChannel.cs" />
<Compile Include="$(CommonPath)\Internal\Padding.cs">
<Link>Common\Internal\Padding.cs</Link>
</Compile>
<Compile Include="$(CommonPath)\System\Collections\Concurrent\SingleProducerConsumerQueue.cs">
<Link>Common\System\Collections\Concurrent\SingleProducerConsumerQueue.cs</Link>
</Compile>
Expand Down
12 changes: 3 additions & 9 deletions src/System.Threading.Tasks.Dataflow/src/Internal/Padding.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,15 @@
// =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

using System.Runtime.InteropServices;
using Internal;

namespace System.Threading.Tasks.Dataflow.Internal
{
/// <summary>A placeholder class for common padding constants and eventually routines.</summary>
internal static class Padding
{
/// <summary>A size greater than or equal to the size of the most common CPU cache lines.</summary>
internal const int CACHE_LINE_SIZE = 128;
}

/// <summary>Value type that contains single Int64 value padded on both sides.</summary>
[StructLayout(LayoutKind.Explicit, Size = 2 * Padding.CACHE_LINE_SIZE)]
[StructLayout(LayoutKind.Explicit, Size = 2 * PaddingHelpers.CACHE_LINE_SIZE)]
internal struct PaddedInt64
{
[FieldOffset(Padding.CACHE_LINE_SIZE)]
[FieldOffset(PaddingHelpers.CACHE_LINE_SIZE)]
internal Int64 Value;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
using System.Collections.Generic;
using System.Diagnostics;
using System.Runtime.InteropServices;
using Internal;

namespace System.Threading.Tasks
{
Expand Down Expand Up @@ -541,18 +542,4 @@ public T[] Items
}
}
}


/// <summary>A placeholder class for common padding constants and eventually routines.</summary>
static class PaddingHelpers
{
/// <summary>A size greater than or equal to the size of the most common CPU cache lines.</summary>
internal const int CACHE_LINE_SIZE = 128;
}

/// <summary>Padding structure used to minimize false sharing in SingleProducerSingleConsumerQueue{T}.</summary>
[StructLayout(LayoutKind.Explicit, Size = PaddingHelpers.CACHE_LINE_SIZE - sizeof(Int32))]
struct PaddingFor32
{
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@
<Compile Include="Internal\SpscTargetCore.cs" />
<Compile Include="Internal\TargetCore.cs" />
<Compile Include="Internal\TargetRegistry.cs" />
<Compile Include="$(CommonPath)\Internal\Padding.cs">
<Link>Common\Internal\Padding.cs</Link>
</Compile>
</ItemGroup>
<ItemGroup Condition="'$(TargetGroup)' == 'netstandard1.0' OR '$(TargetGroup)' == 'netstandard1.1'">
<Compile Include="Internal\Threading.cs" />
Expand Down
2 changes: 1 addition & 1 deletion tools-local/ILAsmVersion.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.2.0-preview1-26514-05
2.2.0-preview1-26515-05