Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[release/2.1] pal_signal: add missing mutex unlock when SIGCHLD==SIG_IGN (#29843)#29845

Closed
stephentoub wants to merge 1 commit intodotnet:release/2.1from
stephentoub:port29843
Closed

[release/2.1] pal_signal: add missing mutex unlock when SIGCHLD==SIG_IGN (#29843)#29845
stephentoub wants to merge 1 commit intodotnet:release/2.1from
stephentoub:port29843

Conversation

@stephentoub
Copy link
Copy Markdown
Member

)

Child reapping was changed to be triggered by the SIGCHLD signal (dotnet#26291).
As part of that change, code was added to handle the original handler being SIG_IGN.
In that case, there was a missing mutex unlock.

Fixes https://github.com/dotnet/corefx/issues/29841.
@stephentoub stephentoub changed the title pal_signal: add missing mutex unlock when SIGCHLD==SIG_IGN (#29843) [release/2.1] pal_signal: add missing mutex unlock when SIGCHLD==SIG_IGN (#29843) May 22, 2018
@stephentoub stephentoub added this to the 2.1.x milestone May 22, 2018
Copy link
Copy Markdown
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting 😄

@danmoseley danmoseley added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label May 22, 2018
@stephentoub
Copy link
Copy Markdown
Member Author

https://github.com/dotnet/corefx/issues/29841#issuecomment-392932234

@danmosemsft, so this should be closed now?

@danmoseley
Copy link
Copy Markdown
Member

Yes, thanks.

@danmoseley danmoseley closed this May 29, 2018
@stephentoub stephentoub deleted the port29843 branch July 4, 2018 04:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

* NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants