Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-26613-04, preview1-26613-07, preview1-26613-01, beta-26613-00, beta-26613-00, servicing-26419-02, respectively (master)#30338
Conversation
|
Discarded CI Status: 1:x: 14:heavy_check_mark: (click to expand)
|
983f8d0 to
11b55d9
Compare
|
Discarded CI Status: 4:x: 3:hourglass: 8:heavy_check_mark: (click to expand)
|
11b55d9 to
fff52a7
Compare
|
@luqunl, it looks like this is failing due to WinRT stuff, e.g. Can you take a look and fix as-is appropriate? |
|
Discarded CI Status: 5:x: 10:heavy_check_mark: (click to expand)
|
fff52a7 to
e373f6b
Compare
|
Discarded CI Status: 6:x: 9:heavy_check_mark: (click to expand)
|
e373f6b to
e752923
Compare
|
Discarded CI Status: 6:x: 1:hourglass: 8:heavy_check_mark: (click to expand)
|
…tandard to preview1-26613-04, preview1-26613-07, preview1-26613-01, beta-26613-00, beta-26613-00, servicing-26419-02, respectively
e752923 to
decfa53
Compare
|
@stephentoub , I am working on it. |
|
The following testcase failed on Linux X64-- #30289
Condition(s) not met: "IsElevatedAndCanWriteToPerfCounters"
Program terminated with signal SIGABRT, Aborted. |
|
@stephentoub, who should take a look these testcase failures? |
|
Couldn't update this pull request: Head commit author 'luqunl' is not 'dotnet-maestro-bot' |
|
Couldn't update this pull request: Head commit author 'luqunl' is not 'dotnet-maestro-bot' |
|
Couldn't update this pull request: Head commit author 'luqunl' is not 'dotnet-maestro-bot' |
|
Couldn't update this pull request: Head commit author 'luqunl' is not 'dotnet-maestro-bot' |
|
@jkotas, @tmat, System.Reflection.Metadata tests are crashing on Linux with this coreclr update: |
|
Also looks like a test failed before this happened: |
|
This looks like JIT regression, likely caused by dotnet/coreclr#18418 . I have created dotnet/coreclr#18469 / dotnet/coreclr#18470 to see whether reverting this change is going to fix the problem. cc @CarolEidt @dotnet/jit-contrib |
|
@jkotas - I can't make out from the output where the failure is occurring - can you clarify? (i.e. how would one go about repro'ing this). |
|
The failure is occurring when running System.Reflection.Metadata tests. However, it is occurring in dotnet/coreclr#18470 with your change is reverted, so you change is unlikely to be the problem. I am binary searching for the offending commit now... |
|
I have traced the problem down to: dotnet/coreclr#18358 To repro the problem: The build output from the last line will have the command line to use to run the xunit directly. It is using runtime from |
|
It will be difficult to revert dotnet/coreclr#18358 as dotnet/coreclr#18346 and dotnet/coreclr#18364 depend on the change. |
|
Ugh. We can disable the failing corefx test then, but it is something that should be looked into with high priority. I have noticed that struct-related tests are failing with current JIT on Unix in CoreRT too (dotnet/corert#5920) so the bug is likely going to hit in multiple different places. |
|
It is not a single tests that it is failing unfortunately. I think we will need to wait for the fix. |
|
@jkotas - I will make that my top priority to track this down. |
Yes. Before your recent fix - everything was failing on both Windows and Unix. After your recent fix - there are still a few tests failing on Unix only. I will try to extract a small repro. |
|
Couldn't update this pull request: Head commit author 'luqunl' is not 'dotnet-maestro-bot' |
|
Couldn't update this pull request: Head commit author 'luqunl' is not 'dotnet-maestro-bot' |
|
Couldn't update this pull request: Head commit author 'luqunl' is not 'dotnet-maestro-bot' |
|
Couldn't update this pull request: Head commit author 'luqunl' is not 'dotnet-maestro-bot' |
|
Couldn't update this pull request: Head commit author 'luqunl' is not 'dotnet-maestro-bot' |
Small repro extracted from the failing CoreRT test: https://github.com/dotnet/coreclr/issues/18482 |
|
@jkotas - with dotnet/coreclr#18483, this test no longer crashes (that is, it completes and prints the "TEST EXECUTION SUMMARY". But the |
It does not fail for me . All System.Reflection.Metadata tests are passing with dotnet/coreclr#18483. |
|
Closing to enable picking up coreclr changes. |
No description provided.