This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Duplicate the access token passed to WindowsIdentity.RunImpersonated (#30346)#30372
Closed
kouvel wants to merge 1 commit intodotnet:release/2.1from
kouvel:ImpersonateFixRel
Closed
Duplicate the access token passed to WindowsIdentity.RunImpersonated (#30346)#30372kouvel wants to merge 1 commit intodotnet:release/2.1from kouvel:ImpersonateFixRel
kouvel wants to merge 1 commit intodotnet:release/2.1from
kouvel:ImpersonateFixRel
Conversation
…30346) So that callbacks for async work initiated while impersonated may continue to impersonate even after the original access token had been disposed. Port of #30346 to release/2.1 Fixes https://github.com/dotnet/corefx/issues/30275 * Small fix * Address feedback * Change to use ref counting, remove assert (no null check on access token parameter) * Manual add/release
Author
|
I'd like to make another change first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that callbacks for async work initiated while impersonated may continue to impersonate even after the original access token had been disposed.
Port of #30346 to release/2.1
Fixes https://github.com/dotnet/corefx/issues/30275