Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[release/2.1] Duplicate the access token passed to WindowsIdentity.RunImpersonated (#30346)#30379

Merged
stephentoub merged 3 commits intodotnet:release/2.1from
kouvel:ImpersonateFixRel
Jun 27, 2018
Merged

[release/2.1] Duplicate the access token passed to WindowsIdentity.RunImpersonated (#30346)#30379
stephentoub merged 3 commits intodotnet:release/2.1from
kouvel:ImpersonateFixRel

Conversation

@kouvel
Copy link

@kouvel kouvel commented Jun 14, 2018

So that callbacks for async work initiated while impersonated may continue to impersonate even after the original access token had been disposed.

Port of #30346 and #30377 to release/2.1
Fixes https://github.com/dotnet/corefx/issues/30275

@kouvel kouvel added this to the 2.1.x milestone Jun 14, 2018
@kouvel kouvel self-assigned this Jun 14, 2018
@kouvel kouvel requested a review from stephentoub June 14, 2018 00:27
…30346)

So that callbacks for async work initiated while impersonated may continue to impersonate even after the original access token had been disposed.

Port of #30346 and #30377 to release/2.1
Fixes https://github.com/dotnet/corefx/issues/30275

* Small fix

* Address feedback

* Change to use ref counting, remove assert (no null check on access token parameter)

* Manual add/release
@stephentoub stephentoub changed the title Duplicate the access token passed to WindowsIdentity.RunImpersonated (#30346) [release/2.1] Duplicate the access token passed to WindowsIdentity.RunImpersonated (#30346) Jun 14, 2018
Koundinya Veluri added 2 commits June 13, 2018 22:55
@LeroyPakade
Copy link

I Upgraded to 2.1.2 the issue went away but now getting error : "This is usually a temporary error during hostname resolution and means that the local server did not receive a response from an authoritative server"

Impersenate error.txt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants