This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Update XUnit Console Runner Dependency#30567
Merged
Merged
Conversation
jkotas
approved these changes
Jun 20, 2018
sergiy-k
approved these changes
Jun 21, 2018
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@60d51a6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rolls the runner forward to pick up the changes introduced with dotnet/buildtools#2035 . The changes wrap around the current runner, so this shouldn't have any functional difference to current testing.
I realize the goal is to move away from the custom runner, but until xunit/xunit#1734 is merged and the changes picked up, this will make test exclusions work.
The goal of this is to be able to run CoreFX tests under CoreCLR ( dotnet/coreclr#18365 ) with a Helix Test payload URL ( without necessarily needing to rebuild tests locally ).
The size of both versions is 56K so there shouldn't be any impact on payload sizes.
cc @sergiy-k @jkotas @BruceForstall @RussKeldorph