Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix compilation for deprecated API on macOS Mojave preview #30716

Merged
maryamariyan merged 2 commits into from
Jun 28, 2018
Merged

Fix compilation for deprecated API on macOS Mojave preview #30716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbec9a5
Fix compilation for deprecated API on macOS Mojave preview
maryamariyan Jun 28, 2018
df6f838
Fixing tests on macOS Mojave
maryamariyan Jun 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Native/Unix/System.Security.Cryptography.Native.Apple/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ set(NATIVECRYPTO_SOURCES
pal_x509chain.c
)

# Temporary workaround for dotnet/corefx issue #30599
add_compile_options(-Wno-deprecated-declarations)

add_library(System.Security.Cryptography.Native.Apple
SHARED
${NATIVECRYPTO_SOURCES}
Expand Down
2 changes: 1 addition & 1 deletion src/Native/Unix/System.Security.Cryptography.Native.Apple/pal_x509chain.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ static void MergeStatusCodes(CFTypeRef key, CFTypeRef value, void* context)
// It doesn't represent a new error code, and we're still getting the old ones, so
// just ignore it for now.
}
else if (CFEqual(keyString, CFSTR("NonEmptySubject")))
else if (CFEqual(keyString, CFSTR("NonEmptySubject")) || CFEqual(keyString, CFSTR("GrayListedKey")))
Copy link
Copy Markdown
Member

@bartonjs bartonjs Jun 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danmosemsft This line we'll want to send to release/2.1 at whatever rate we say we support Mojave

{
// Not a "problem" that we report.
}
Expand Down