Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Allows include build number for packages blocked from going stable#30825

Merged
weshaggard merged 1 commit into
dotnet:release/2.1from
weshaggard:FixBlockStablePackages
Jul 5, 2018
Merged

Allows include build number for packages blocked from going stable#30825
weshaggard merged 1 commit into
dotnet:release/2.1from
weshaggard:FixBlockStablePackages

Conversation

@weshaggard
Copy link
Copy Markdown
Member

For any packages that we doin't want to ship and marked as
BlockStable we should always force include the label and
build number in the package name.

cc @mmitche @ericstj

This changes (3) and (4) from the original commit 4fcf6cf.

  1. StabilizePackageVersions=true, PackageVersionStamp='label'
  • Packages not marked BlockStable will have prelease label 'label'
    and no build number
  • BlockStable packages will have a prelease label 'label' and build
    number
  1. StabilizePackageVersions=true, PackageVersionStamp=''
  • Packages not marked BlockStable will not have a prelease label
    or build number, and thus have a stable version.
  • BlockStable packages will have the prelease label commited in the
    repo and build number

For any packages that we doin't want to ship and marked as
BlockStable we should always force include the label and
build number in the package name.
@weshaggard
Copy link
Copy Markdown
Member Author

@dotnet-bot test this please

@weshaggard
Copy link
Copy Markdown
Member Author

@dotnet-bot test NETFX x86 Release Build

@weshaggard
Copy link
Copy Markdown
Member Author

netfx test run hit https://github.com/dotnet/corefx/issues/30713.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants