This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Adding special target that will get a resource file and pass it to ilasm for S.R.CS.Unsafe so that it has the right version headers#31806
Merged
joperezr merged 2 commits intodotnet:release/2.1from Sep 4, 2018
Conversation
…asm for S.R.CS.Unsafe so that it has the right version headers (dotnet#31782) * Adding special target that will get a resource file and pass it to ilasm for S.R.CS.Unsafe so that it has the right version headers * PR Feedback * Updating buildtools and fixing obj name
Member
Author
|
Note that in order for this to be green, we need to ingest the following buildtools change: dotnet/buildtools#2127 |
jamshedd
added
Servicing-approved
Member
|
Approved for 2.1.5 |
Member
|
@joperezr please merge when this is green - I merged buildtools |
danmoseley
added
Servicing-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24012 . Cherry-picked from #31782 [No Conflicts]
Description
System.Runtime.CompilerServices.Unsafe.dll is an ilproj in our solution, which means we build it by directly calling ILAsm. Because of this, our version headers don't get automatically embedded into the output assembly, which means that the resulting library won't have version information. This is preventing internal customers to consume this library. With the changes on this PR, we are effectively passing in a resource object to the ILAsm call, so that the right version information exists on that library.
Customer Impact
No negative impact. The only difference now will be that the assembly will have version information in it.
Regression?
No
Risk
None.