Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Comments

Fix Vector4ToStringTest to use correct variable for assertion and to wor...#32

Closed
adamralph wants to merge 1 commit intodotnet:masterfrom
adamralph:fix-tests
Closed

Fix Vector4ToStringTest to use correct variable for assertion and to wor...#32
adamralph wants to merge 1 commit intodotnet:masterfrom
adamralph:fix-tests

Conversation

@adamralph
Copy link
Contributor

...k on non en-US culture machines

@mellinoe
Copy link
Contributor

Thanks, looks good.

@FiveTimesTheFun
Copy link
Contributor

I'm continuing to get test failures in SIMD for DEU after pulling this. @mellinoe I'll file an issue to keep looking at globalization all-up for these tests.

@jbuiss0n
Copy link

Hello,

I've fix some tests of the same king (using my CultureInfo "fr-FR"), it should correct for every CultureInfo since i don't put fr-FR specific code.

@adamralph
Copy link
Contributor Author

Yep, that's a further problem. My PR's go some of the way by fixing the
currency format, but to fix for yet more cultures, the hardcoded commas
will need to be replaced with the list separator for the current culture. I
can add to my second PR or send another later, unless someone else does in
the meantime.
On 12 Nov 2014 19:03, "jbuiss0n" notifications@github.com wrote:

Hello,

I've fix some tests of the same king (using my CultureInfo "fr-FR"), it
should correct for every CultureInfo since i don't put fr-FR specific code.


Reply to this email directly or view it on GitHub
#32 (comment).

@mellinoe
Copy link
Contributor

This was fixed in PR #34 . Thanks for the contribution and for helping on that pull request as well, Adam.

@adamralph
Copy link
Contributor Author

My pleasure :-)
On 14 Nov 2014 00:15, "Matt Cohn" notifications@github.com wrote:

Closed #32 #32.


Reply to this email directly or view it on GitHub
#32 (comment).

@adamralph adamralph deleted the fix-tests branch May 16, 2015 10:15
pgavlin added a commit to pgavlin/corefx that referenced this pull request Sep 22, 2015
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants