Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[release/2.1] Bump package version for S.S.C.Pkcs and add it to packages.builds#32111

Closed
bartonjs wants to merge 2 commits intodotnet:release/2.1from
bartonjs:pkcs_package_authoring
Closed

[release/2.1] Bump package version for S.S.C.Pkcs and add it to packages.builds#32111
bartonjs wants to merge 2 commits intodotnet:release/2.1from
bartonjs:pkcs_package_authoring

Conversation

@bartonjs
Copy link
Member

@bartonjs bartonjs commented Sep 4, 2018

This package authoring was missing from the changes for 2.1.3 servicing, resulting in those fixes not making it to customers.

Fixes #32092.

@bartonjs bartonjs added area-System.Security packaging Related to packaging labels Sep 4, 2018
@bartonjs bartonjs self-assigned this Sep 4, 2018
@bartonjs bartonjs requested a review from weshaggard September 4, 2018 22:23
@bartonjs
Copy link
Member Author

bartonjs commented Sep 4, 2018

Description

Package authoring was missing from System.Security.Cryptography.Pkcs for previous release/2.1 changes, resulting in those changes not shipping.

Customer Impact

Customers are still affected by bugs that we fixed.

Regression?

Some of the bugs were regressions from .NET Framework, but this particular change is not a regression.

Risk

Low. The changes have been tested with unit tests for a while, we just didn't actually release them.

@weshaggard
Copy link
Member

It would be good to do a "allconfigurations" build locally to verify the package is built with the expected versions.

@weshaggard
Copy link
Member

D:\j\workspace\windows-TGrou---27e62afc\Tools\Packaging.targets(1131,5): error : PackageIndex from D:\j\workspace\windows-TGrou---27e62afc\pkg\Microsoft.Private.PackageBaseline\packageIndex.json is missing an assembly version entry for 4.0.4.0 for package System.Security.Cryptography.Pkcs.  Please run /t:UpdatePackageIndex on this project to commit an update. [D:\j\workspace\windows-TGrou---27e62afc\src\System.Security.Cryptography.Pkcs\pkg\System.Security.Cryptography.Pkcs.pkgproj]

Need to update the package index as well.

@bartonjs
Copy link
Member Author

bartonjs commented Sep 5, 2018

@weshaggard UpdatePackageIndex made some unrelated changes. I left them in, rather than fight with the tool; but can certainly edit them back out.

@weshaggard
Copy link
Member

@weshaggard UpdatePackageIndex made some unrelated changes. I left them in, rather than fight with the tool; but can certainly edit them back out.

They are just normalization so it is fine to leave them in.

@bartonjs
Copy link
Member Author

bartonjs commented Sep 6, 2018

@dotnet-bot Test OSX x64 Debug Build please (timeout in System.Net.Security.Tests.ServerAsyncAuthenticateTest.ServerAsyncAuthenticate_EachSupportedProtocol_Success(protocol: Tls11))

@karelz karelz added this to the 2.1.x milestone Sep 6, 2018
@danmoseley danmoseley added the Servicing-consider Issue for next servicing release review label Sep 6, 2018
@danmoseley
Copy link
Member

Obsoleted by #32203

@danmoseley danmoseley closed this Sep 11, 2018
@danmoseley danmoseley removed the Servicing-consider Issue for next servicing release review label Sep 11, 2018
@bartonjs bartonjs removed their assignment Nov 23, 2018
@bartonjs bartonjs deleted the pkcs_package_authoring branch October 16, 2019 04:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants