This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Merge in 2.1.4 changes#32229
Merged
weshaggard merged 20 commits intodotnet:release/2.1from Sep 11, 2018
Merged
Conversation
… empty could result in infinite read loop MSRC 46845 The bug was caused by `examined.Segment == _commitHead` comparison. When pipe is empty and read is cancelld cursors are returned with `null` segment value. Then if memory is allocated from pipe before AdvanceTo is called `examined.Segment == _commitHead` condition would return false resulting in pipe never being observed entirely until the first Flush.
* Update packageIndex.json with versions from the 2.1.3 release * Update packages.builds to include System.IO.Pipelines in 2.1.4
* Add System.IO.Pipelines to list of external packages used during harvesting * Add a temporary feed pointing to the 2.1.3 release feed
This feed was added temporarily to get 2.1.4 building before the 2.1.3 release was deployed to nuget.org
Member
Author
|
@weshaggard PTAL |
mmitche
commented
Sep 11, 2018
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" /> | ||
| <PropertyGroup> |
Member
Author
There was a problem hiding this comment.
@wtgodbe @weshaggard Should this be removed in the merge?
Member
There was a problem hiding this comment.
Yes we should remove this otherwise it will conflict with #32203.
weshaggard
approved these changes
Sep 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.