Add missing overloads of hardware intrinsic#32370
Conversation
|
@dotnet-bot test this please |
|
@dotnet-bot test NETFX x86 Release Build |
| public static unsafe Vector128<int> BroadcastScalarToVector128(int* source) { throw null; } | ||
| public static unsafe Vector128<uint> BroadcastScalarToVector128(uint* source) { throw null; } | ||
| public static unsafe Vector128<long> BroadcastScalarToVector128(long* source) { throw null; } | ||
| public static unsafe Vector128<ulong> BroadcastScalarToVector128(ulong* source) { throw null; } |
There was a problem hiding this comment.
Why are we not having double* and single* overloads as well. Broadcast is type agnostic what matters is operand size. Nevermind, this is Avx2
| public static Vector256<int> BlendVariable(Vector256<int> left, Vector256<int> right, Vector256<int> mask) { throw null; } | ||
| public static Vector256<uint> BlendVariable(Vector256<uint> left, Vector256<uint> right, Vector256<uint> mask) { throw null; } | ||
| public static Vector256<long> BlendVariable(Vector256<long> left, Vector256<long> right, Vector256<long> mask) { throw null; } | ||
| public static Vector256<ulong> BlendVariable(Vector256<ulong> left, Vector256<ulong> right, Vector256<ulong> mask) { throw null; } |
There was a problem hiding this comment.
Why are we not having double and single overloads as well. BlendVariable is type agnostic what matters is operand size. Nevermind this is Avx2.
|
@tannergooding @jkotas The "Packaging All Configurations x64 Debug Build" seems to need more work than adding new API surface? Could you help? |
|
@morganbr I do not think we need to be running the API baseline checks for the netcoreappaot configuration. They cause extra busy work for folks adding new APIs. The situations like above are happening several times a week. The fix is always to just add the missing APIs to the baseline, so it is not really adding any value. @fiigii Could you please try to fix this break by changing https://github.com/dotnet/corefx/blob/master/Directory.Build.props#L103 to |
|
@jkotas Thank you so much! Will try. |
There are many APIs that are in netcoreappaot, but not in uapaot. For example, System.Runtime.Intrinsics that is actively being worked on. I am not suggesting to disable the baseline checked for uapaot. |
|
@dotnet-bot test this please |
* Add missing overloads of hardware intrinsic * disable API baseline checks for the netcoreappaot Commit migrated from dotnet/corefx@581627f
7 participants
Match CoreCLR changes dotnet/coreclr#20055 and dotnet/coreclr#19420
@CarolEidt @tannergooding @eerhardt