Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Extend Span<byte>.IndexOfAny(..., ROS) tests#33185

Merged
stephentoub merged 2 commits into
dotnet:masterfrom
benaadams:Span.IndexOfAny
Nov 2, 2018
Merged

Extend Span<byte>.IndexOfAny(..., ROS) tests#33185
stephentoub merged 2 commits into
dotnet:masterfrom
benaadams:Span.IndexOfAny

Conversation

@benaadams
Copy link
Copy Markdown
Member

@benaadams benaadams commented Nov 1, 2018

Comment thread src/System.Memory/tests/ReadOnlySpan/IndexOfAny.byte.cs Outdated
Comment thread src/System.Memory/tests/ReadOnlySpan/IndexOfAny.byte.cs Outdated
Comment thread src/System.Memory/tests/ReadOnlySpan/IndexOfAny.byte.cs Outdated
Copy link
Copy Markdown
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments, LGTM. Thanks for adding these.

@benaadams
Copy link
Copy Markdown
Member Author

Simplified tests

Copy link
Copy Markdown
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@stephentoub stephentoub merged commit fc4cb1d into dotnet:master Nov 2, 2018
EgorBo pushed a commit to EgorBo/corefx that referenced this pull request Nov 4, 2018
* Extend Span<byte>.IndexOfAny(..., ROS) tests

* Simplify tests
@karelz karelz added this to the 3.0 milestone Nov 15, 2018
@benaadams benaadams deleted the Span.IndexOfAny branch January 11, 2019 21:36
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Extend Span<byte>.IndexOfAny(..., ROS) tests

* Simplify tests


Commit migrated from dotnet/corefx@fc4cb1d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants