This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add SequenceReader<T>#33288
Merged
Merged
Conversation
Initial add of ReadOnlySequence<T> reader. Includes search and binary read functionality. Perf tests will be ported from CoreFXlab later. Parse functionality still being discussed.
stephentoub
reviewed
Nov 7, 2018
stephentoub
reviewed
Nov 7, 2018
stephentoub
reviewed
Nov 7, 2018
stephentoub
reviewed
Nov 7, 2018
stephentoub
reviewed
Nov 7, 2018
stephentoub
reviewed
Nov 7, 2018
stephentoub
reviewed
Nov 7, 2018
stephentoub
reviewed
Nov 7, 2018
stephentoub
reviewed
Nov 7, 2018
stephentoub
reviewed
Nov 7, 2018
stephentoub
reviewed
Nov 7, 2018
stephentoub
reviewed
Nov 7, 2018
stephentoub
reviewed
Nov 7, 2018
stephentoub
reviewed
Nov 7, 2018
ahsonkhan
reviewed
Nov 7, 2018
JeremyKuhne
commented
Nov 7, 2018
|
Update the package description? Line 1046 in 684704d |
ahsonkhan
reviewed
Nov 8, 2018
| private readonly object _dummy; | ||
| private readonly int _dummyPrimitive; | ||
| public SequencePosition(object @object, int integer) { throw null; } | ||
| [System.ComponentModel.EditorBrowsableAttribute((System.ComponentModel.EditorBrowsableState)(1))] |
There was a problem hiding this comment.
Why did this end up getting removed? I would revert this change, build the ref and src, and then run the generate command from within the ref directory. Please let me know if you are still seeing such side effects/unintended changes.
Member
Author
There was a problem hiding this comment.
The build target did it.
Member
Author
There was a problem hiding this comment.
Manually added them back for now.
ahsonkhan
reviewed
Nov 8, 2018
ahsonkhan
reviewed
Nov 8, 2018
| } | ||
| public ref partial struct SequenceReader<T> where T : struct, System.IEquatable<T> | ||
| { | ||
| public SequenceReader(System.Buffers.ReadOnlySequence<T> buffer) { throw null; } |
There was a problem hiding this comment.
Regenerate based on new sources so that arg names match.
Member
Author
There was a problem hiding this comment.
Whoops, sorry, missed this comment. I'll fix shortly.
ahsonkhan
reviewed
Nov 8, 2018
ahsonkhan
reviewed
Nov 8, 2018
ahsonkhan
reviewed
Nov 8, 2018
ahsonkhan
reviewed
Nov 8, 2018
ahsonkhan
reviewed
Nov 8, 2018
ahsonkhan
reviewed
Nov 8, 2018
Member
Author
|
It is never expected to throw.
From: Ahson Khan <notifications@github.com>
@ahsonkhan commented on this pull request.
…________________________________
In src/System.Memory/src/System/Buffers/SequenceReader.cs<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fcorefx%2Fpull%2F33288%23discussion_r231737626&data=02%7C01%7Cjeremy.kuhne%40microsoft.com%7C7a8e4f973e234c529a0208d64517f958%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636772366605577629&sdata=ExiLShzLyQ8NXJVL5s1daTlld8oQXFYnrWjR%2Fbw3FcA%3D&reserved=0>:
Yes, but is it expected for this to ever throw or is that an indication that something went wrong? I am not sure if that's the behaviour we want. And if it is, we should document exactly why we throw and why it's acceptable
|
Then, why not add the debug.assert and/or comment? |
danmoseley
reviewed
Nov 8, 2018
Member
Author
Because an assert here would give you no useful information. In any case, that code no longer exists as I removed |
… as we don't have the same pattern yet for the other overloads.
ericstj
reviewed
Nov 8, 2018
jkotas
reviewed
Nov 8, 2018
stephentoub
reviewed
Nov 9, 2018
| { | ||
| int escapeCount = 0; | ||
| for (int i = remaining.Length; i > 0 && remaining[i - 1].Equals(delimiterEscape); i--, escapeCount++) | ||
| ; |
Member
There was a problem hiding this comment.
Nit: there seems to be some inconsistency as to whether loops with empty bodies just use ; or have empty braces.
Member
Author
There was a problem hiding this comment.
Is this something we've called out in our guidelines? I'll massage it either way.
stephentoub
reviewed
Nov 9, 2018
| /// Move the reader back the specified number of items. | ||
| /// </summary> | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public void Rewind(long count) |
Member
There was a problem hiding this comment.
It's the right trade-off for Rewind to be forcibly inlined?
Member
Author
There was a problem hiding this comment.
We believe so. It is only the fast path and is expected to be used frequently in some scenarios. I'll look to push the count check to the slow path like I did for advance to make this a bit better.
stephentoub
approved these changes
Nov 9, 2018
Member
Author
|
@dotnet-bot test OSX x64 Debug Build |
ahsonkhan
reviewed
Nov 10, 2018
| <Compile Include="SequenceReader\OwnedArray.cs" /> | ||
| <Compile Include="SequenceReader\ReadTo.cs" /> | ||
| <Compile Include="SequenceReader\Rewind.cs" /> | ||
| <Compile Include="SequenceReader\SequenceSegment.cs" /> |
There was a problem hiding this comment.
nit: alphabetical ordering. swap SequenceSegment/SequenceFactory
Member
|
👍🏿 |
Member
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Add SequenceReader<T> Initial add of ReadOnlySequence<T> reader. Includes search and binary read functionality. Perf tests will be ported from CoreFXlab later. Parse functionality still being discussed. * Address feedback, fix non coreapp test builds. * Replace Peek() with TryCopyTo() * Address more feedback. Removing TryReadTo without advancePastDelmiter as we don't have the same pattern yet for the other overloads. * Rename files to not use underscore. * Fix uap builds * Move TryRead to SequenceMarshal and other feedback. * Tweak file name casing (part1) * Change casing pt 2. * Change package common types Commit migrated from dotnet/corefx@ab9570b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial add of
ReadOnlySequence<T>reader. Includes search and binary read functionality.Perf tests will be ported from CoreFXlab later. Text parsing functionality still being discussed and is not included in this change.
See https://github.com/dotnet/corefx/issues/32588.
cc: @joshfree, @danmosemsft, @davidfowl, @terrajobst, @ericstj (for packaging)