This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Revert "Add another Zip IEnumerable<T> extension method (#26582)"#33709
Merged
stephentoub merged 1 commit intodotnet:masterfrom Nov 27, 2018
Merged
Revert "Add another Zip IEnumerable<T> extension method (#26582)"#33709stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
This reverts commit 6b2b9e4.
bartonjs
approved these changes
Nov 27, 2018
agocke
approved these changes
Nov 27, 2018
Member
Author
|
Thanks, Andy and Jeremy. |
jlennox
pushed a commit
to jlennox/corefx
that referenced
this pull request
Dec 16, 2018
…" (dotnet#33709) This reverts commit 6b2b9e4.
stephentoub
added a commit
that referenced
this pull request
Feb 26, 2019
stephentoub
added a commit
that referenced
this pull request
Feb 27, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…x#26582)" (dotnet/corefx#33709) This reverts commit dotnet/corefx@6b2b9e4. Commit migrated from dotnet/corefx@53ae9af
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…et/corefx#26582)"" (dotnet/corefx#35595) * Revert "Revert "Add another Zip IEnumerable<T> extension method (dotnet/corefx#26582)" (dotnet/corefx#33709)" This reverts commit dotnet/corefx@53ae9af. * Adapt to ThrowHelper changes Commit migrated from dotnet/corefx@720591a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6b2b9e4 (using
git revert 6b2b9e42097df84f9b1504fe7d14e9b64f8f0870, no conflicts).The new Enumerable.Zip overload was added with PascalCased element names, which frustrates some folks, just as camelCased names would frustrate others, and potentially even no names. Until we re-review and come up with the long-term story for how we want to (or not) expose ValueTuples in .NET public APIs, I'm removing this overload so we don't accidentally ship it as-is. In the meantime, it's easy for someone to accomplish themselves without the overload, e.g. using the existing overload
Enumerable.Zip(first, second, (f,s) => (f,s))instead ofEnumerable.Zip(first, second).cc: @terrajobst, @jaredpar, @bartonjs, @agocke, @cston
Related to https://github.com/dotnet/corefx/issues/33553