Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Add tests for ResourceManager on custom Assembly type.#34617

Merged
stephentoub merged 1 commit into
dotnet:masterfrom
filipnavara:getsat
Feb 12, 2019
Merged

Add tests for ResourceManager on custom Assembly type.#34617
stephentoub merged 1 commit into
dotnet:masterfrom
filipnavara:getsat

Conversation

@filipnavara
Copy link
Copy Markdown
Member

@filipnavara filipnavara commented Jan 16, 2019

Unit tests for dotnet/coreclr#21979. /cc @jkotas

stephentoub
stephentoub reviewed Jan 17, 2019
View reviewed changes
Comment thread src/System.Resources.ResourceManager/tests/CustomAssemblyTests.cs Outdated
stephentoub
stephentoub reviewed Jan 17, 2019
View reviewed changes
Comment thread src/System.Resources.ResourceManager/tests/CustomAssemblyTests.cs Outdated
stephentoub
stephentoub reviewed Jan 17, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@filipnavara
Copy link
Copy Markdown
Member Author

filipnavara commented Jan 25, 2019

Following discussion in dotnet/coreclr#21979 I started over. Now it's a unit test that ensures that custom assemblies cannot be passed to the ResourceManager constructor.

@filipnavara
Copy link
Copy Markdown
Member Author

filipnavara commented Jan 26, 2019

/AzurePipelines run corefx-ci

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jan 26, 2019

4 builds created, 3 builds couldn't be queued.

@filipnavara
Copy link
Copy Markdown
Member Author

filipnavara commented Jan 29, 2019

/AzurePipelines run corefx-ci

1 similar comment
@filipnavara
Copy link
Copy Markdown
Member Author

filipnavara commented Jan 31, 2019

/AzurePipelines run corefx-ci

@filipnavara
Copy link
Copy Markdown
Member Author

filipnavara commented Jan 31, 2019

@dotnet-bot test Packaging All Configurations x64 Debug Build

@MarcoRossignoli
Copy link
Copy Markdown
Member

MarcoRossignoli commented Feb 1, 2019

AzurePipelines commands seems broken #34747 (comment)

@filipnavara
Copy link
Copy Markdown
Member Author

filipnavara commented Feb 1, 2019

@MarcoRossignoli Thanks, I am aware of the issue, but I kinda hoped it was fixed meanwhile :)

@filipnavara
Copy link
Copy Markdown
Member Author

filipnavara commented Feb 4, 2019

/AzurePipelines run corefx-ci

@filipnavara
Copy link
Copy Markdown
Member Author

filipnavara commented Feb 4, 2019

@safern Is there any (public) issue that tracks the state of Azure Pipelines triggers on GitHub?

@safern
Copy link
Copy Markdown
Member

safern commented Feb 5, 2019

@safern Is there any (public) issue that tracks the state of Azure Pipelines triggers on GitHub?

No, there was not one. I just opened: https://github.com/dotnet/corefx/issues/35121 -- we're supposed to get the fix by Friday or Monday according to their team.

@safern
Copy link
Copy Markdown
Member

safern commented Feb 5, 2019

I just retried your build manually 😄

@stephentoub stephentoub merged commit 24450da into dotnet:master Feb 12, 2019
@karelz karelz added this to the 3.0 milestone Mar 18, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@filipnavara @stephentoub
Add tests for ResourceManager on custom Assembly type. (dotnet/corefx…
641a19b 
…#34617)

Commit migrated from dotnet/corefx@24450da
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@stephentoub stephentoub stephentoub left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@filipnavara @MarcoRossignoli @safern @stephentoub @karelz