Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix UapAot runs#34678

Merged
ViktorHofer merged 2 commits into
dotnet:masterfrom
ViktorHofer:UapAotFix
Jan 24, 2019
Merged

Fix UapAot runs#34678
ViktorHofer merged 2 commits into
dotnet:masterfrom
ViktorHofer:UapAotFix

Conversation

@ViktorHofer
Copy link
Copy Markdown
Member

@ViktorHofer ViktorHofer commented Jan 18, 2019

Depends on dotnet/arcade#1627
Fixes https://github.com/dotnet/corefx/issues/30423

Using the xunit.console runner fork compiled with /p:DefineConstants=WINDOWS_UWP for uapaot.

Additional changes:

  • Improve test run time by removing one ilc invocation for the RemoteExecutorConsoleApp which is part of the runner itself, same as on uap.
  • Update UWP runner to .NET Core 2.2 and streamline cod with the added fork so that only one code base remains.
  • Minor code cleanup in the CoreFxTesting package.

cc @danmosemsft @MichalStrehovsky @Lxiamail @joshfree @MattGal

Copy link
Copy Markdown
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, with the caveat I did not test it...

@ViktorHofer
Copy link
Copy Markdown
Member Author

@dotnet-bot test this please

@ViktorHofer ViktorHofer force-pushed the UapAotFix branch 2 times, most recently from 4ff9464 to ea12908 Compare January 22, 2019 23:47
@ViktorHofer
Copy link
Copy Markdown
Member Author

@dotnet-bot test UWP CoreCLR x64 Debug Build

@ViktorHofer ViktorHofer force-pushed the UapAotFix branch 2 times, most recently from faf14ff to 3b1cda4 Compare January 23, 2019 13:45
@ViktorHofer ViktorHofer force-pushed the UapAotFix branch 3 times, most recently from 756f581 to 6d101e3 Compare January 23, 2019 21:29
@ViktorHofer ViktorHofer merged commit 4adc562 into dotnet:master Jan 24, 2019
@ViktorHofer ViktorHofer deleted the UapAotFix branch January 24, 2019 11:56
@karelz karelz added this to the 3.0 milestone Mar 18, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Fix UapAot runs

* Darc update from build '20190124.1'


Commit migrated from dotnet/corefx@4adc562
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants