Native: Multiple fixes

[ghost]

067ea11 d9cf2d8

• Fix wrong cast. Clang on FreeBSD caught this as error as id_t is not the type [get/set]priority functions are expecting:
  • Linux man (uses id_t who): http://man7.org/linux/man-pages/man2/getpriority.2.html
  • FreeBSD man (uses int who): https://www.freebsd.org/cgi/man.cgi?query=getpriority&sektion=2 (this applies to other BSDs as well, such as DragonFly and NetBSD, except for OpenBSD, hence I've used #if !defined(BSD) .. cmake_prototype_definition to detect the correct prototype).

207d186 e348434

• Removes unrequired dependencies from native src/Native/gen-buildsys-clang.sh.
  • It builds without llvm-* dependencies.
  • Cleanup unused code blocks.
  • Minor conditions and comment fixes.

[stephentoub]

cc: @nguerrera, @sokket

[nguerrera]

Out of curiosity, why is this needed?

[ghost]

This is for the check #ifdef BSD:
sys/param.h is available in all POSIX and BSD macro is only defined in BSD-backed OSes. (ref: http://sourceforge.net/p/predef/wiki/OperatingSystems/, https://technet.microsoft.com/en-us/library/bb463220.aspx)

[nguerrera]

Thanks, @jasonwilliams200OK. I had two comments, but the rest looks good.

[nguerrera]

Just found a third issue: Are we even using locate_llvm_exec or llvm_prefix anymore?

[ghost]

Nice catch! I thought it is used to check llvm existence and early exit. Fixed by 9e22f86.

[ghost]

Thanks for the review @nguerrera. I have fixed the issues and re-pushed.

Regarding the assert comment, do you want me to address it by checking id_t width vs. int32_t (using sizeof operator) as part of this PR?

[nguerrera]

Nevermind the assert since it was already missing. (Aside: Note that sizeof() check isn't sufficient since it doesn't account for possible difference in signedness between int32_t and id_t.)

I'm going to make another change to make potentially narrowing conversions like that go through a helper that also avoids having to cmake configure every occurrence like this. It'll also help clean up some things in the crypto shim.

This LGTM once it gets through a successful CI.