Add codecov yml configuration #34896
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| codecov: | ||
| branch: master | ||
| ci: | ||
| - dnceng.visualstudio.com | ||
|
|
||
| coverage: | ||
| range: 60...90 | ||
|
There was a problem hiding this comment. ❔ Can you describe the motivation behind this range? I always recommend that teams using code coverage tools never gate on a particular coverage number, but I can think of other reasons why this might be included. I'm curious why it's used here.
Member
Author
There was a problem hiding this comment. I lowered the lower bound temporarily as our coverage numbers aren't great for most of our libraries. As soon as codecov integration is enabled in corefx I will adjust these settings based on what makes sense. |
||
|
|
||
| comment: | ||
| layout: "reach, diff, files" | ||
|
There was a problem hiding this comment. 💡 |
||
| require_changes: yes | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ Can you provide more information about what this does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure: https://docs.codecov.io/docs/detecting-ci-services#section-detection-technique.
As we upload our reports from helix machines, the codecov's detection technique fails and can't figure out which CI service is used. We ideally should set this variable in the teams codecov yml but I don't permissions to do so: https://docs.codecov.io/docs/codecov-yaml#section-team-yaml