This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Handle the case where the Marshal.ThrowExceptionForHR is inlined in#34968
Merged
stephentoub merged 1 commit intodotnet:masterfrom Jan 31, 2019
Merged
Handle the case where the Marshal.ThrowExceptionForHR is inlined in#34968stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
the test assembly and the Source isn't corlib.
AaronRobinsonMSFT
added
test bug
Member
Author
stephentoub
reviewed
Jan 30, 2019
| Assert.Equal("mscorlib", ex.Source); | ||
| } | ||
|
|
||
| string sourceMaybe = PlatformDetection.IsNetCore |
Member
There was a problem hiding this comment.
Is this going to work correctly on .NET Native? Mono?
Member
There was a problem hiding this comment.
Though I guess this was the logic we already had?
Member
Author
There was a problem hiding this comment.
That is a great question. I have no idea. I assumed the logic of choice was correct. How would/could I verify this?
Member
Author
There was a problem hiding this comment.
Though I guess this was the logic we already had?
Yep. I just added the option of the result being the current assembly. I had hoped this was already passing on other runtimes.
stephentoub
approved these changes
Jan 30, 2019
This was referenced Apr 3, 2019
Merged
jkotas
pushed a commit
to dotnet/coreclr
that referenced
this pull request
Apr 5, 2019
Disabled the two tests that were fixed in PR dotnet/corefx#34968
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…otnet/corefx#34968) the test assembly and the Source isn't corlib. Commit migrated from dotnet/corefx@09bac5f
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Disabled the two tests that were fixed in PR dotnet/corefx#34968 Commit migrated from dotnet/coreclr@8deef30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the test assembly and the Source isn't corlib.
cc @stephentoub @jkoritzinsky