Manual darc update for arcade and coreclr#34977
Conversation
@stephentoub I guess PlatformID got pushed down to coreclr? |
|
I see. Found your PR: #34654 Will fix it and update this PR. |
safern
force-pushed
the
ManualDarcUpdateArcadeCoreclr
branch
2 times, most recently
from
c234109 to
76b6d63
Compare
|
It seems like uapaot doesn't yet have Environment exposed as public. Still compiling with the internal type rather than the files coming from the shared location. Is that missing to do in corert? I just conditioned everything for uapaot to keep using the local copies. Until that is done there, we can't delete the files. |
|
@dotnet-bot test Linux x64 Release Build please |
safern
force-pushed
the
ManualDarcUpdateArcadeCoreclr
branch
from
76b6d63 to
c8c5a7c
Compare
| <ProjectGuid>{844A2A0B-4169-49C3-B367-AFDC4894E487}</ProjectGuid> | ||
| <Configurations>netcoreapp-Windows_NT-Debug;netcoreapp-Windows_NT-Release;netstandard-Debug;netstandard-Release;netstandard1.0-Debug;netstandard1.0-Release;netstandard1.2-Debug;netstandard1.2-Release;uap-Windows_NT-Debug;uap-Windows_NT-Release;uapaot-Windows_NT-Debug;uapaot-Windows_NT-Release</Configurations> | ||
| <DefineConstants>$(DefineConstants);SYSTEM_RUNTIME_WINDOWSRUNTIME_ASSEMBLY</DefineConstants> | ||
| <DefineConstants Condition="'$(TargetGroup)' == 'uapaot'">$(DefineConstants);SYSTEM_RUNTIME_WINDOWSRUNTIME_ASSEMBLY</DefineConstants> |
There was a problem hiding this comment.
Because for netcoreapp we can’t use Environment from System.Runtime.Extensions since it conflicts because it is now a typeforward, and since this project has a reference from runtime to System.Private.Corelib, it conflicts with the new Environment type exposed there, so we can’t use the alias for it.
However since the type for the version we have in corefx of ProjectN is internal in corelib, we need to resolve this type from System.Runtime.Extensions until we get a new ProjectN with the PR you just merged. We don’t use this constant anywhere else, right?
There was a problem hiding this comment.
I see, the compiler didn't like resolving the typeforward through the alias? Seems like a that might be a compiler bug.
There was a problem hiding this comment.
We don’t use this constant anywhere else, right?
Right. Ok. My plan was to remove it entirely once everything flowed through the system.
There was a problem hiding this comment.
Not related to this commit, but this project warrants some comments as to why it does such weird things. It's not a partial facade yet it's compiling against private surface area from System.Private.CoreLib which is why its using project references and aliases. It'd be really nice if that could be cleaned up. /cc @jeffschwMSFT
|
* Remove target to print MCUrl now that helix sdk always prints it * Run darc update for dotnet/arcade * Run darc update for dotnet\coreclr * Fix build after Environment pushed down to coreclr Commit migrated from dotnet/corefx@28c46ef
4 participants
@stephentoub this should unblock your PR to enable Decimal test cases.