This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Update dependencies from dotnet/core-setup#35217
Merged
Merged
Conversation
Contributor
Author
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Member
|
It look like the latest netcoreapp package has |
Contributor
Author
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Member
Contributor
Author
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Member
|
ping @sywhang ? |
Member
|
I'd just recommend adding the typeforwards (deleting source file reference from CSPROJ). If folks wanted something different than they can come back and fix it. |
|
Is deleting the source file reference from the CSPROJ for System.Diagnostics.Tracing the only thing I need to do to add typeforwards? Sorry I'm not very familiar with this space... |
Member
|
I just pushed a commit. I'll take care of it. |
Member
|
Actually based on the conflicts I realized it was just fixed on: 45b49ee |
added 2 commits
February 11, 2019 16:54
…0190210.1 This change updates the following dependencies - Microsoft.NETCore.App - 3.0.0-preview-27410-1 - Microsoft.NETCore.DotNetHost - 3.0.0-preview-27410-1 - Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview-27410-1
…0190210.5 This change updates the following dependencies - Microsoft.NETCore.App - 3.0.0-preview-27410-5 - Microsoft.NETCore.DotNetHost - 3.0.0-preview-27410-5 - Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview-27410-5
safern
force-pushed
the
darc-master-059be939-a178-4d39-a8e6-66062064f92d
branch
from
6036bed to
d4d30f8
Compare
Member
|
Just rebased and pushed so that it contains the changes that fixes the type conflicts. |
Member
|
Actually what this PR needs is a new version of core-setup that contains the new changes of corefx that have the typeforwards, because currently the type exists in two places in the Microsoft.NETCore.App package which comes from core-setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Updates from https://github.com/dotnet/core-setup
Updates from https://github.com/dotnet/core-setup