Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Expose and test APIs for some threading metrics (CoreFX)#35502

Closed
kouvel wants to merge 8 commits into
dotnet:masterfrom
kouvel:ThreadMetricsFx
Closed

Expose and test APIs for some threading metrics (CoreFX)#35502
kouvel wants to merge 8 commits into
dotnet:masterfrom
kouvel:ThreadMetricsFx

Conversation

@kouvel
Copy link
Copy Markdown

@kouvel kouvel commented Feb 21, 2019

@kouvel kouvel added this to the 3.0 milestone Feb 21, 2019
@kouvel kouvel self-assigned this Feb 21, 2019
@kouvel kouvel requested a review from stephentoub February 21, 2019 20:50
@karelz karelz added * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) blocked Issue/PR is blocked on something - see comments labels Mar 4, 2019
@kouvel kouvel removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 30, 2019
@karelz karelz removed the blocked Issue/PR is blocked on something - see comments label Apr 1, 2019
@karelz
Copy link
Copy Markdown
Member

karelz commented Apr 1, 2019

@kouvel do you plan to update the change and push the PR forward now that we have API review?

@kouvel
Copy link
Copy Markdown
Author

kouvel commented Apr 2, 2019

I have updated to remove local/global versions of PendingWorkItemCount. They can be added in the future if they would be useful. I think all three PRs (CoreCLR, CoreRT, and CoreFX) are now ready for review. @stephentoub, would you be able to take a look?

@kouvel
Copy link
Copy Markdown
Author

kouvel commented Apr 3, 2019

The test in the latest commit is not exactly testing for the ordering issue that I mentioned in dotnet/corert#7066, that would be more difficult to repro without adding a similar race between the Values getter and Dispose, and adding any synchronization to ensure that ordering would not repro the issue. So it would not be an issue when the caller is expected to ensure that Dispose does not race with the Values getter. The test seemed like a somewhat reasonable expectation though.

@kouvel kouvel mentioned this pull request Apr 3, 2019
Merged
kouvel added a commit that referenced this pull request Apr 5, 2019
@kouvel
Add a timer test (#36576)
c575bed 
Add a timer test

- Separated from #35502
- Added test from dotnet/corert#7069 to CoreFX
@karelz
Copy link
Copy Markdown
Member

karelz commented Apr 13, 2019

@kouvel still working on it?

@kouvel
Copy link
Copy Markdown
Author

kouvel commented Apr 16, 2019

Yea still working on it, currently blocked on CI failures in dotnet/coreclr#22754, doesn't look like my change but trying to get a clean run

@kouvel kouvel mentioned this pull request May 3, 2019
Merged
@kouvel
Copy link
Copy Markdown
Author

kouvel commented May 3, 2019

Continued in #37401

@kouvel kouvel closed this May 3, 2019
@kouvel kouvel deleted the ThreadMetricsFx branch May 3, 2019 11:06
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@kouvel
Add a timer test (dotnet/corefx#36576)
3eea518 
Add a timer test

- Separated from dotnet/corefx#35502
- Added test from dotnet/corert#7069 to CoreFX

Commit migrated from dotnet/corefx@c575bed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub Awaiting requested review from stephentoub

Assignees

@kouvel kouvel

Labels

area-System.Threading

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kouvel @karelz