Add Pull Request Builds documentation#35672
Conversation
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
Besides the nits that are already expressed LGTM
|
Thank you very much @safern! |
| ``` | ||
| /azp help (displays help message) | ||
| /azp run (runs all builds listed above) | ||
| /azp run <build name> (/azp run corefx-outerloop-linux) |
There was a problem hiding this comment.
@safern, could we create a corefx-outerloop such that I could type just /azp run corefx-outerloop and it would run all three of the OS-specific outerloops listed above?
There was a problem hiding this comment.
I'll investigate if this is possible. I'm not sure if we can achieve that, but we might be able to do so. I'll double check.
There was a problem hiding this comment.
In order to do this now, we would need to add a new dummy pipeline that does nothing, and then chain the other 3 pipelines to be triggered when that is finished. Are we OK with having a new pipeline that will always show green even though one of the others failed?
I will however talk to Azure DevOps folks, to maybe add a feature, to be able to specify a grouping name when triggering through comments or something like that.
There was a problem hiding this comment.
I just added a tracking issue for aliases/tags on a build, so that we don't have to do ugly workarounds.
There was a problem hiding this comment.
Ok, so I tried that workaround where we would add a dummy build and trigger the other 3 builds and the way this is structured in azure pipelines, won't actually work for PRs. What we could do is add an extra build (corefx-outerloop) which runs the whole outerloop matrix. If you want to just run osx, then you call corefx-outerloop-osx directly.
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Thanks for writing this up.
|
/azp run corefx-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Add Pull Request Builds documentation * PR Feedback Commit migrated from dotnet/corefx@f709c10
8 participants
Fixes: #35288
This doc is for contributors or members to use when in doubt of how our pull request builds work. Ideas or new entries are welcome. You can view at: https://github.com/dotnet/corefx/blob/2a60ef1630e8050a18632217d682b5675287ac49/Documentation/project-docs/pullrequest-builds.md
At the bottom of the doc there is a
Known issuessection which I will be updating once this issues are fixed and creating PRs to announce it broadly.cc: @danmosemsft @ViktorHofer @ericstj @tannergooding @maryamariyan @stephentoub @Anipik @JeremyKuhne @jkotas @karelz @dotnet/ncl @MarcoRossignoli @Wraith2 @krwq @afsanehr @vcsjones