This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix NetEventSource logging for Windows auth on Linux#35918
Merged
davidsh merged 1 commit intodotnet:masterfrom Mar 10, 2019
Merged
Fix NetEventSource logging for Windows auth on Linux#35918davidsh merged 1 commit intodotnet:masterfrom
davidsh merged 1 commit intodotnet:masterfrom
Conversation
While debugging some Linux enterprise auth (Negotiate/NTLM) scenarios, I discoverd that the logging I added in PR dotnet#35383 wasn't working. This was due to not passing in a 'null' value for the context object for NetEventSource.Info. It was using the string object as the context object and not logging the string data. As part of fixing that I optimized some code for remembering what auth package (NTLM or SPNEGO) is used.
davidsh
force-pushed
the
ntauth_logging_fix
branch
from
a502963 to
954a0f3
Compare
stephentoub
approved these changes
Mar 10, 2019
Contributor
Author
|
/azp run corefx-outerloop-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Drawaes
pushed a commit
to Drawaes/corefx
that referenced
this pull request
Mar 11, 2019
While debugging some Linux enterprise auth (Negotiate/NTLM) scenarios, I discovered that the logging I added in PR dotnet#35383 wasn't working. This was due to not passing in a 'null' value for the context object for NetEventSource.Info. It was using the string object as the context object and not logging the string data. As part of fixing that I optimized some code for remembering what auth package (NTLM or SPNEGO) is used.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…5918) While debugging some Linux enterprise auth (Negotiate/NTLM) scenarios, I discovered that the logging I added in PR dotnet/corefx#35383 wasn't working. This was due to not passing in a 'null' value for the context object for NetEventSource.Info. It was using the string object as the context object and not logging the string data. As part of fixing that I optimized some code for remembering what auth package (NTLM or SPNEGO) is used. Commit migrated from dotnet/corefx@21db29a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging some Linux enterprise auth (Negotiate/NTLM) scenarios, I discovered that the
logging I added in PR #35383 wasn't working. This was due to not passing in a 'null' value
for the context object for NetEventSource.Info. It was using the string object as the
context object and not logging the string data.
As part of fixing that I optimized some code for remembering what auth package (NTLM
or SPNEGO) is used.