This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add ReadOnlySequence<T>.FirstSpan#36194
Merged
maryamariyan merged 4 commits intodotnet:masterfrom Mar 29, 2019
Merged
Conversation
stephentoub
reviewed
Mar 20, 2019
|
@maryamariyan, consider making this a draft PR while in progress. This way, the WIP/No merge label become unnecessary. Something to consider for the future. See https://github.blog/2019-02-14-introducing-draft-pull-requests/ |
60975cd to
1e6920c
Compare
Fixes: #33029
1e6920c to
3b16714
Compare
maryamariyan
commented
Mar 25, 2019
ahsonkhan
reviewed
Mar 25, 2019
4d1ae89 to
3b16714
Compare
Author
|
I added benchmarks for FirstSpan in the new performance repo. (dotnet/performance#410 (comment)) |
ahsonkhan
approved these changes
Mar 28, 2019
How about for string and |
Author
|
I just updated my comment to also include numbers for string and |
a98a7c2 to
69e7107
Compare
maryamariyan
commented
Mar 28, 2019
69e7107 to
c1dbbd9
Compare
ahsonkhan
reviewed
Mar 29, 2019
ahsonkhan
approved these changes
Mar 29, 2019
Author
|
Linux failure related to Fedora 27 queues leaving Helix. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Add ReadOnlySequence<T>.FirstSpan Fixes: dotnet/corefx#33029 Commit migrated from dotnet/corefx@8292e45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #33029
cc: @ahsonkhan