This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Improve System.Native build experience for new platforms#36926
Merged
Conversation
Member
Author
|
/cc @janvorli, @safern, @ViktorHofer |
ViktorHofer
approved these changes
Apr 16, 2019
Member
|
Thanks! |
safern
approved these changes
Apr 16, 2019
Member
Author
|
Can this be merged? :) |
stephentoub
approved these changes
Apr 18, 2019
Contributor
|
@am11 @ViktorHofer @stephentoub Note that the renaming of If possible, please remember to notify us for any future change to this to avoid breaking us again. |
Member
Author
|
Sorry about that @BruceForstall, I was only grep'ing the CoreFX repo. Maybe we can try sharing/centralizing them via arcade (if possible). :) |
Member
|
@BruceForstall sorry about that. Sure thing next time we will let you know next time. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-native.shviaBuildNativeClangas MSBuild property;/p:BuildNativeClang. This PR renames it toBuildNativeCompilerso it doesn't look confusing when selecting GCC compiler:corefx/build.sh /p:BuildNativeCompiler=-gcc.NOT OPENSSL_FOUNDwith those of KRB5 and CURL etc., so user knows which missing package to install.* Currently there is no way to pass more than one arguments via
BuildNativeCompiler, as they get stripped somewhere inengdirectory incorefx/build.sh -> ... -> corefx/src/Native/build-native.shcall chain. For example, we cannot do:because a pass-through script strips away the quotes.