Embedded resources may not have extension in the name#37048
Embedded resources may not have extension in the name#37048danmoseley merged 7 commits intodotnet:masterfrom
Conversation
…having any extensions.
|
Corresponding Winforms run-time changes are in this PR. |
|
Is this for Preview 5? With the last merge into release in Monday, if there is a matching winforms change, we should make sure both are in or both are out. My suggestion is we hold on both, since this repo is so close to the last merge. |
|
|
||
| // All bitmap images from winforms runtime are changed to Icons | ||
| // and logical names, now, does not contain any extension. | ||
| rawbmpname = name; |
There was a problem hiding this comment.
Is a test possible? We do have tests for this class.
|
This is a less risky change on corefx side and independant of Winforms change (if winforms change can't make it, it will be no-op on corefx). Modernizing winforms icons was Preview 5 item. I can look into a possible test. |
|
@danmosemsft, are you suggesting we hold this until Preview snap is done and go to Preview 6? |
|
@dreddy-work it's up to you. If it's not needed for preview 5 I suggest to wait a few hours. If it is required, feel free to merge. |
…om/dreddy-work/corefx into user/dreddy/ImageLogicalNameChange
|
@danmosemsft , @safern can you please help merge this? |
|
done. |
…37048) * Bitmaps are replaced with Icons and Logical names are changed to not having any extensions. * Checking for Rawformat before calling MakeTransparent method. * Adding a test attribute * Adding test. Commit migrated from dotnet/corefx@27d0597
4 participants
Winforms run-time is replacing the embedded bitmap resources to Icons that match with VisualStudio styles. Winforms also made change to logical names ( earlier they contain file name with extension ".bmp". now that the files are changed ti .ICO files, we are removing the extension from logical names for future proof)