This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Updating arcade dependencies to get the fix for destinationSubDirectory#37309
Closed
joperezr wants to merge 1 commit intodotnet:masterfrom
Closed
Updating arcade dependencies to get the fix for destinationSubDirectory#37309joperezr wants to merge 1 commit intodotnet:masterfrom
joperezr wants to merge 1 commit intodotnet:masterfrom
Conversation
bb5389a to
5a2471e
Compare
tarekgh
approved these changes
Apr 30, 2019
5a2471e to
b677e7d
Compare
Member
|
@safern how come there's no URL in the build log to go to MC? just |
Member
|
I’m on my phone and I can’t copy from the logs but I do see the MC url just above. You copied the error summary, but before that you can see the URL right after the job was sent. |
safern
suggested changes
May 1, 2019
| <runtimenativeSystemIOPortsPackageVersion>4.6.0-preview6.19229.9</runtimenativeSystemIOPortsPackageVersion> | ||
| <!-- Standard dependencies --> | ||
| <NETStandardLibraryPackageVersion>2.1.0-prerelease.19230.1</NETStandardLibraryPackageVersion> | ||
| <NETStandardLibraryPackageVersion>2.1.0-prerelease.19221.1</NETStandardLibraryPackageVersion> |
Member
There was a problem hiding this comment.
This is downgrading NETStandardLibrary package version and that would break official builds. How did you run the arcade update? Net standard should come from another channel.
Member
Author
|
Closing this PR in favor of #37326 which is the official update PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37246
cc: @tarekgh