Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Updating arcade dependencies to get the fix for destinationSubDirectory#37309

Closed
joperezr wants to merge 1 commit intodotnet:masterfrom
joperezr:UpdateDependencies
Closed

Updating arcade dependencies to get the fix for destinationSubDirectory#37309
joperezr wants to merge 1 commit intodotnet:masterfrom
joperezr:UpdateDependencies

Conversation

@joperezr
Copy link
Copy Markdown
Member

Fixes #37246

cc: @tarekgh

@joperezr joperezr force-pushed the UpdateDependencies branch from bb5389a to 5a2471e Compare April 30, 2019 20:05
@joperezr joperezr force-pushed the UpdateDependencies branch from 5a2471e to b677e7d Compare April 30, 2019 22:25
@danmoseley
Copy link
Copy Markdown
Member

@safern how come there's no URL in the build log to go to MC? just

C:\Users\VssAdministrator\.nuget\packages\microsoft.dotnet.helix.sdk\2.0.0-beta.19230.4\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(67,5): error : Work item Microsoft.VisualBasic.Core.Tests in job d0f1f549-79bf-4f9c-93d0-782acb1281be has failed. [D:\a\1\s\eng\sendtohelix.proj]
C:\Users\VssAdministrator\.nuget\packages\microsoft.dotnet.helix.sdk\2.0.0-beta.19230.4\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(67,5): error : Job 'd0f1f549-79bf-4f9c-93d0-782acb1281be' failed 1 out of 254216 tests. [D:\a\1\s\eng\sendtohelix.proj]

``

@safern
Copy link
Copy Markdown
Member

safern commented May 1, 2019

I’m on my phone and I can’t copy from the logs but I do see the MC url just above. You copied the error summary, but before that you can see the URL right after the job was sent.

Comment thread eng/Versions.props
<runtimenativeSystemIOPortsPackageVersion>4.6.0-preview6.19229.9</runtimenativeSystemIOPortsPackageVersion>
<!-- Standard dependencies -->
<NETStandardLibraryPackageVersion>2.1.0-prerelease.19230.1</NETStandardLibraryPackageVersion>
<NETStandardLibraryPackageVersion>2.1.0-prerelease.19221.1</NETStandardLibraryPackageVersion>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is downgrading NETStandardLibrary package version and that would break official builds. How did you run the arcade update? Net standard should come from another channel.

@joperezr
Copy link
Copy Markdown
Member Author

joperezr commented May 1, 2019

Closing this PR in favor of #37326 which is the official update PR.

@joperezr joperezr closed this May 1, 2019
@joperezr joperezr deleted the UpdateDependencies branch May 1, 2019 17:23
@karelz karelz added this to the 3.0 milestone May 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build and test layout incorrect when consuming classlib with satellite assembly.

5 participants