Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

troubleshooting OleDb failures#37540

Merged
maryamariyan merged 8 commits intodotnet:masterfrom
maryamariyan:oledb-tests
May 10, 2019
Merged

troubleshooting OleDb failures#37540
maryamariyan merged 8 commits intodotnet:masterfrom
maryamariyan:oledb-tests

Conversation

@maryamariyan
Copy link
Copy Markdown

@maryamariyan maryamariyan commented May 9, 2019

  • re-enable running oledb tests
  • fix OleDbTestBase implementation
  • add missing using statements
  • disable running tests in parallel
  • cleanup tests

Fixes: https://github.com/dotnet/corefx/issues/37538

@maryamariyan maryamariyan marked this pull request as ready for review May 9, 2019 21:03
@ViktorHofer ViktorHofer closed this May 9, 2019
@ViktorHofer ViktorHofer reopened this May 9, 2019
@ViktorHofer ViktorHofer closed this May 9, 2019
@ViktorHofer ViktorHofer reopened this May 9, 2019
@maryamariyan maryamariyan reopened this May 9, 2019
@maryamariyan maryamariyan requested a review from saurabh500 May 10, 2019 18:26
@maryamariyan
Copy link
Copy Markdown
Author

maryamariyan commented May 10, 2019

@saurabh500 Fixes the SEHException failues and re-enables OLEDB tests.
The OleDbTestBase class contains fields command, connection, transaction that can be used for each test.
I also revisited the Dispose method of OleDbTestBase which itself is derived from FileCleanupTestBase class.

I disabled tests running in parallel and made sure there is only one OleDbConnection being used at each time for any test.

@danmoseley
Copy link
Copy Markdown
Member

Do you know exactly why the SEHException was happening? Or it just seems somehow one of your changes fixed it?

@maryamariyan
Copy link
Copy Markdown
Author

maryamariyan commented May 10, 2019

I waited for the result of CI reports on each commit to get produced before pushing up the next commit to see which one fixes it.
Pretty much I think the fix had to do with the combination of (1) making sure the disposable objects are getting used and disposed of properly and also (2) especially in the OleDbConnection tests I made sure there is only one connection open at a time to reduce complication.

@maryamariyan maryamariyan merged commit 2c64705 into dotnet:master May 10, 2019
@maryamariyan maryamariyan deleted the oledb-tests branch May 10, 2019 21:06
@danmoseley
Copy link
Copy Markdown
Member

Makes sense. thanks!

@karelz karelz added this to the 3.0 milestone May 22, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure in System.Data.OleDb tests SEHException - External component has thrown an exception

4 participants