[System.Text.Json] Fix bug complex properties#37586
[System.Text.Json] Fix bug complex properties#37586MarcoRossignoli wants to merge 3 commits intodotnet:masterfrom MarcoRossignoli:jsonbug
Conversation
|
|
||
| if (!propertyInfo.ShouldDeserialize) | ||
| { | ||
| return false; |
There was a problem hiding this comment.
If I understood well we should return true only if we're sure to be at the end of json object root
I would add a test with properties that have private setters like the one that was stated in the original issue (both for top-level properties, and for complex properties/nested). |
|
Close because I confirm that update #37578 fix bug my tests passed. cc: @steveharter @ahsonkhan |
Both of them? #37567 as well? @steveharter consider adding the test cases from @MarcoRossignoli from this PR into yours. |
I think so I did some test with @steveharter clone and sample on #37567 works |
fixes https://github.com/dotnet/corefx/issues/37536
fixes https://github.com/dotnet/corefx/issues/37567
Suggest me more test case if needed.
cc: @steveharter @ahsonkhan