This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix missing casts in Enumerable.Select assert#37699
Merged
stephentoub merged 1 commit intodotnet:masterfrom May 17, 2019
Merged
Fix missing casts in Enumerable.Select assert#37699stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
stephentoub
reviewed
May 16, 2019
stephentoub
approved these changes
May 16, 2019
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
One nit to be addressed, otherwise LGTM. Thanks.
stephentoub
changed the title
stephentoub
reviewed
May 16, 2019
| { | ||
| Debug.Assert(start < end); | ||
| Debug.Assert((end - start) <= int.MaxValue); | ||
| Debug.Assert(unchecked((uint)(end - start) <= (uint)int.MaxValue)); |
Member
There was a problem hiding this comment.
Suggested change
| Debug.Assert(unchecked((uint)(end - start) <= (uint)int.MaxValue)); | |
| Debug.Assert((uint)(end - start) <= (uint)int.MaxValue); |
Contributor
Author
There was a problem hiding this comment.
OK, I will force push to change the commit.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #37410 missed casts.