This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add interleaved comments to JsonSerializer tests#37712
Merged
ahsonkhan merged 1 commit intodotnet:masterfrom May 17, 2019
Merged
Add interleaved comments to JsonSerializer tests#37712ahsonkhan merged 1 commit intodotnet:masterfrom
ahsonkhan merged 1 commit intodotnet:masterfrom
Conversation
Contributor
Author
|
Test failures on corefx-ci (Windows x86) appear to be unrelated (System.Drawing.Tests). |
ahsonkhan
added
area-System.Text.Json
test enhancement
ahsonkhan
approved these changes
May 17, 2019
| var options = new JsonSerializerOptions(); | ||
| options.ReadCommentHandling = JsonCommentHandling.Skip; | ||
|
|
||
| int[][] i = JsonSerializer.Parse<int[][]>(Encoding.UTF8.GetBytes("[[1,2] // Inline [\n,[3, /* Multi\n]] Line*/4]]"), options); |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@18ddda0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per this PR comment #37549 (comment) this adds tests for interleaved comments within JSON objects and arrays.
cc @ahsonkhan