Enable rolling builds and add arm64 in outerloop#37728
Enable rolling builds and add arm64 in outerloop#37728ViktorHofer merged 7 commits intodotnet:masterfrom
Conversation
|
@safern the official build ran successfully. |
| - template: /eng/pipelines/helix.yml | ||
| parameters: | ||
| # send tests to helix only on public builds, official scheduled builds or manual official builds. | ||
| condition: or(eq(${{ parameters.isOfficialBuild }}, False), notIn(variables['Build.Reason'], 'BatchedCI', 'IndividualCI')) |
There was a problem hiding this comment.
Github won't let me comment on line 188 but maybe we could instead of using a condition here, use a ${{ if }} condition so that this step doesn't always show as skipped on official builds and that way the logs are smaller there.
- ${{ if eq(parameters.isOfficialBuild, 'false') }}:
- template: /eng/pipelines/helix.yml
...Then you can remove this condition parameter entirely.
There was a problem hiding this comment.
I thought about it but I don't think this is necessary. This will only be skipped in official builds and nobody looks at it unless something breaks.
There was a problem hiding this comment.
Yeah, I agree on that but, it is nice to have less steps showed as skipped the logs would be cleaner. Up to you.
safern
left a comment
safern
left a comment
There was a problem hiding this comment.
Left a couple of comments I would like to be addressed before merging. Good stuff, now you're a yml expert 😄
* Enable rolling builds and add arm64 in outerloop * Disable tests on official builds * Allow Outerloop to run aggregated * Disable failing RH6 test Commit migrated from dotnet/corefx@9643d42
3 participants
... and enable RedHat6 on PRs.
cc @wtgodbe