This repository was archived by the owner on Jan 23, 2023. It is now read-only.
System.Text.Json is not inbox on netfx#38077
Merged
wtgodbe merged 1 commit intodotnet:masterfrom May 31, 2019
Merged
Conversation
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s), but failed to run 1 pipeline(s). |
safern
approved these changes
May 30, 2019
ahsonkhan
approved these changes
May 31, 2019
Member
Author
|
Test failures are either known outerloop issues, or known infra failures on MUSL. |
Member
|
@wtgodbe please use azp run only when you want to trigger Outerloop. In this case I guess you just wanted to retrigger CI which you can do by either push force your amended commit or retrigger via the AzDO checks page. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@40983e2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes test build break introduced by 1743e47
corefx/src/System.Text.Json/tests/Serialization/Value.ReadTests.cs
Lines 224 to 227 in 30ca411
These tests were failing on netfx, since System.Text.Json isn't inbox on that platform, but the ifdef wasn't catching that after we added
netfxto the test configurations: https://github.com/dotnet/corefx/blame/master/src/System.Text.Json/tests/Configurations.propsCC @safern @ViktorHofer @ahsonkhan