This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Removing the TestAllOnes, TestAllZeros, and TestMixOnesZeros methods from the Sse41 class#38102
Merged
tannergooding merged 2 commits intodotnet:masterfrom May 31, 2019
tannergooding:fix-34882
Merged
Removing the TestAllOnes, TestAllZeros, and TestMixOnesZeros methods from the Sse41 class#38102tannergooding merged 2 commits intodotnet:masterfrom tannergooding:fix-34882
tannergooding merged 2 commits intodotnet:masterfrom
tannergooding:fix-34882
Conversation
…from the Sse41 class
stephentoub
approved these changes
May 31, 2019
eerhardt
approved these changes
May 31, 2019
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
LGTM
Will there be a corresponding coreclr change to remove these from CoreLib?
Member
Author
Yes, but that does not need to be in before the snap today. Once the reference assembly is updated, we can freely remove the JIT support without worrying about it being a breaking change. |
Member
Author
|
coreclr side is up here: dotnet/coreclr#24886 |
Always best to allow a little time, to avoid unnecessary pain :-) |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…from the Sse41 class (dotnet/corefx#38102) * Removing the TestAllOnes, TestAllZeros, and TestMixOnesZeros methods from the Sse41 class * Adding a MatchingRefApiCompatBaseline for System.Runtime.Intrinsics Commit migrated from dotnet/corefx@39c1f79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves https://github.com/dotnet/corefx/issues/34882.
CC. @CarolEidt, @terrajobst, @danmosemsft